Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[Config] Allow to always use config classes#51544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:7.4
Are you sure you want to change the base?
[Config] Allow to always use config classes#51544
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for working on this, it's related to the limitation I found in#51273 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The changes on the Config components are BC breaks. Can we find a way that doesn't break BC?
| @@ -374,7 +374,7 @@ protected function createNode(): NodeInterface | |||
| if ($this->default) { | |||
| if (!\is_array($this->defaultValue)) { | |||
| throw new \InvalidArgumentException(sprintf('%s: the default value of an array node has to be an array.', $node->getPath())); | |||
| throw new \InvalidArgumentException(sprintf('"%s": the default value of an array node has to be an array.', $node->getPath())); | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should be reverted, that's a false-positive from fabbot I suppose
| protected $node; | ||
| public $allowedTypes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
removing consts and public properties is a BC break, we need to figure out a way that doesn't break BC
- undo changes fromsymfony#44166
f4bb242 to72e1fd0Compare
When the config node doesn't have normalization, using the config object is impossible.
When the config node has some array normalization (like
http_codesin\Symfony\Bundle\FrameworkBundle\DependencyInjection\Configuration::addHttpClientRetrySection), it is not possible to use the config object.This PR relates to changes introduced in: