Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Scheduler] Trigger unique messages at runtime#51542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fa83bdb to777c5a4CompareUh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Tests/Generator/MessageGeneratorTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
a969434 to8869bd7CompareUh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Scheduler/Trigger/CallbackMessageProvider.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It looks good to me. I've made a few small suggestions.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d9a196e toe98bbe3CompareUh oh!
There was an error while loading.Please reload this page.
fabpot commentedSep 27, 2023
Thank you@Jeroeny. |
Jeroeny commentedSep 27, 2023
Thanks! |
Uh oh!
There was an error while loading.Please reload this page.
The messages in a schedule (
RecurringMessage) are created at compile time, per Trigger. This means a trigger will always give the same message. This limits the usefulness of the component, because messages can often be dynamic. E.g. with a specific payload from the database or with a Uuid per message (often the case with architectures like EventSourcing / cqrs).Also there is no way for a trigger to only 'check' what the getNextRunDate is, without always triggering a message.
This PR makes it possible to yield zero or more messages when a trigger is triggered. Due to the trigger being a method, the messages can be created at runtime, with a unique payload (or directly serving messages from a DB table).
Since the component is still experimental in 6.3, it's probably good to get something like this in before 6.4 is released.