Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Scheduler] Trigger unique messages at runtime#51542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromJeroeny:schedule
Sep 27, 2023

Conversation

@Jeroeny
Copy link
Contributor

@JeroenyJeroeny commentedSep 3, 2023
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT

The messages in a schedule (RecurringMessage) are created at compile time, per Trigger. This means a trigger will always give the same message. This limits the usefulness of the component, because messages can often be dynamic. E.g. with a specific payload from the database or with a Uuid per message (often the case with architectures like EventSourcing / cqrs).
Also there is no way for a trigger to only 'check' what the getNextRunDate is, without always triggering a message.

This PR makes it possible to yield zero or more messages when a trigger is triggered. Due to the trigger being a method, the messages can be created at runtime, with a unique payload (or directly serving messages from a DB table).
Since the component is still experimental in 6.3, it's probably good to get something like this in before 6.4 is released.

axzx, Tona-Mangobyte, Zuruuh, and mohamedhn37 reacted with thumbs up emojidragoonis and magaliescobar reacted with heart emoji
@JeroenyJeroenyforce-pushed theschedule branch 2 times, most recently froma969434 to8869bd7CompareSeptember 15, 2023 09:45
Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks good to me. I've made a few small suggestions.

@fabpot
Copy link
Member

Thank you@Jeroeny.

@Jeroeny
Copy link
ContributorAuthor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@kbondkbondAwaiting requested review from kbondkbond is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@Jeroeny@fabpot@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp