Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AssetMapper] Allow specifying packages to update with importmap:update#51523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jmsche
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

Currently, theimportmap:update command updates all packages.

This PR allows specifying which packages the developer wants to update.

smnandre and welcoMattic reacted with hooray emoji
@jmsche
Copy link
ContributorAuthor

Failure of Unit Tests (8.2, low-deps) seems unrelated

Copy link
Member

@stofstof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should be covered by tests in the ImportMapManagerTest IMO.

Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great - I'm happy to see how simple this is. Only a few comments related to the test

@jmsche
Copy link
ContributorAuthor

@weaverryan Test updated 👍

Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure what to do about pslam - it IS related, but not related to the new changes.

@jmsche
Copy link
ContributorAuthor

jmsche commentedSep 4, 2023•
edited
Loading

@weaverryan Not sure either :/ Note that I only added the@return detail, it already returned this value before.

@fabpotfabpotforce-pushed theimportmap-update-specify-package branch from75bc3e5 to4d57c41CompareSeptember 10, 2023 08:58
@fabpot
Copy link
Member

Thank you@jmsche.

@fabpotfabpot merged commit2cfaa9d intosymfony:6.4Sep 10, 2023
@jmschejmsche deleted the importmap-update-specify-package branchSeptember 19, 2023 06:45
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@weaverryanweaverryanweaverryan approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@jmsche@fabpot@weaverryan@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp