Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Messenger] Fix routing to multiple fallback transports#51508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@valtzu
Copy link
Contributor

@valtzuvaltzu commentedAug 28, 2023
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
LicenseMIT

The change made in#48121 means that it's not possible to route into multiple transport as fallback like

framework:messenger:routing:My\Message\*:[async, audit]

F.e. the messageMy\Message\ToBeSentToTwoSenders would only reachasync.

The comment in the code mentions

if other senders already matchedwith previous types, skip the senders bound to the fallback

While in reality how it works is

if other senders already matched, skip the senders bound to the fallback

After the changes in this MR it works as mentioned in the original comment, meaning it does not skip for the same type, but routes to all transports for that type.


This is not a BC break because anyone who has more than one transport in a wildcard rule has never received anything matching the wildcard on other than the 1st transport – so only if you had a misconfiguration in the first place you're affected.

@valtzu
Copy link
ContributorAuthor

valtzu commentedAug 29, 2023
edited
Loading

@wouterj Could you take a look at this when you have time, since you made the original PR?

@nicolas-grekas
Copy link
Member

Thank you@valtzu.

@nicolas-grekasnicolas-grekas merged commit04c7ccf intosymfony:6.3Sep 29, 2023
@fabpotfabpot mentioned this pull requestSep 30, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

3 participants

@valtzu@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp