Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] no serializer mapping cache in debug mode without enable_annotations#51497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@soyuka
Copy link
Contributor

@soyukasoyuka commentedAug 27, 2023•
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets#51497
LicenseMIT
Doc PRnot needed

There's no reason we should disable the cache only withoutenable_annotations, when working only with attributes, in debug mode the cache is enabled which is why we often need to clear cache when changing a serialized object to get the changes.

@fabpot
Copy link
Member

Please, keep the full header in the description.

…nable_annotationsThere's no reason we should disable the cache only without `enable_annotations`, when working only with attributes, in debug mode the cache is enabled which is why we often need to clear cache when changing a serialized object to get the changes.
@soyukasoyukaforce-pushed thefix/serializer-mapping-cache-debug branch from2de525a to4312e96CompareSeptember 13, 2023 07:14
@soyuka
Copy link
ContributorAuthor

done I guess you spoke about the commit description

@nicolas-grekas
Copy link
Member

Thank you@soyuka.

@nicolas-grekasnicolas-grekas merged commite065f2e intosymfony:5.4Sep 14, 2023
This was referencedSep 30, 2023
@bastnic
Copy link
Contributor

The reason is that for yaml/xml, it's ban by CachePoolClearerCacheWarmer (from apip...) from this PRhttps://github.com/symfony/symfony/pull/35109/files.

With that PR, it means that all yaml/xml are parsed at each request without any change :(.

@xabbuh
Copy link
Member

@bastnic comments on merged PRs are likely to get lost. Please open a new issue if you think that you discovered an issue with this implementation and provide a small example application that allows to reproduce it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dunglasdunglasdunglas approved these changes

@derrabusderrabusderrabus approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

8 participants

@soyuka@fabpot@nicolas-grekas@bastnic@xabbuh@dunglas@derrabus@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp