NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

Fixed attachment base64 content string in MailerSendApiTransport#51494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.3frompavelwitassek:patch-1

Aug 26, 2023

Merged

Fixed attachment base64 content string in MailerSendApiTransport#51494

fabpot merged 1 commit intosymfony:6.3frompavelwitassek:patch-1

Aug 26, 2023

Conversation

Copy link

Contributor

pavelwitassek commentedAug 26, 2023

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix#51492
License	MIT

Fix base64 encoded body string of larger attachments in MailerSendApiTransport

Fixed attachment base64 content string in MailerSendApiTransport

5580080

carsonbot added Status: Needs Review Bug labels

Aug 26, 2023

carsonbot added this to the6.3 milestone

Aug 26, 2023

Copy link

carsonbot commentedAug 26, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot