Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][Routing] Deprecate annotations#51483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedAug 25, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsPart of#51381
LicenseMIT
Doc PR-
  • Deprecate therouting.loader.annotation service, use therouting.loader.attribute service instead
  • Deprecate therouting.loader.annotation.directory service, use therouting.loader.attribute.directory service instead
  • Deprecate therouting.loader.annotation.file service, use therouting.loader.attribute.file service instead
  • DeprecateAnnotationClassLoader, useAttributeClassLoader instead
  • DeprecateAnnotationDirectoryLoader, useAttributeDirectoryLoader instead
  • DeprecateAnnotationFileLoader, useAttributeFileLoader instead
  • DeprecateAnnotatedRouteControllerLoader, useAttributeRouteControllerLoader

dmaicher and jvasseur reacted with thumbs up emojiGromNaN, hhamon, and fmonts reacted with heart emoji
@alexandre-dauboisalexandre-dauboisforce-pushed therouter-annotation-loader-deprec branch from8f9bdda toe0426c9CompareAugust 25, 2023 11:48
@alexandre-dauboisalexandre-dauboisforce-pushed therouter-annotation-loader-deprec branch frome0426c9 toda057c7CompareOctober 2, 2023 08:16
@alexandre-daubois
Copy link
MemberAuthor

Rebased and conflicts fixed

@nicolas-grekasnicolas-grekas added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 6, 2023
@alexandre-dauboisalexandre-dauboisforce-pushed therouter-annotation-loader-deprec branch 3 times, most recently fromc476880 to0ea026eCompareOctober 9, 2023 07:23
@fancyweb
Copy link
Contributor

Instead of the current strategy, what about copy-pasting the existing Annotation classes code in the new Attribute classes, and then make existing Annotation classes extends those new Attribute classes.

@alexandre-dauboisalexandre-dauboisforce-pushed therouter-annotation-loader-deprec branch from0ea026e tob559652CompareOctober 15, 2023 10:36
@alexandre-daubois
Copy link
MemberAuthor

@fancyweb I think that the current way of doing is better for upmerges. It will be easier for potential fixes if the annotation classes remain the same. Otherwise, all fixes inAnnotation*Loader will have to be manually reflected inAttribute*Loader when merging to upper branches

@alexandre-dauboisalexandre-dauboisforce-pushed therouter-annotation-loader-deprec branch 4 times, most recently from9b778bf to94c5354CompareOctober 15, 2023 11:02
@alexandre-dauboisalexandre-dauboisforce-pushed therouter-annotation-loader-deprec branch 10 times, most recently from85d87ae toe51fe86CompareOctober 17, 2023 11:46
@nicolas-grekasnicolas-grekasforce-pushed therouter-annotation-loader-deprec branch frome51fe86 to708b1b6CompareOctober 17, 2023 13:59
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The class_alias trick is the best!

alexandre-daubois reacted with rocket emoji
@nicolas-grekas
Copy link
Member

Thank you@alexandre-daubois.

@alexandre-daubois
Copy link
MemberAuthor

I'll work on the cleanup 🙂

@alexandre-dauboisalexandre-daubois deleted the router-annotation-loader-deprec branchOctober 18, 2023 11:03
nicolas-grekas added a commit that referenced this pull requestOct 18, 2023
… (alexandre-daubois)This PR was merged into the 7.0 branch.Discussion----------[FrameworkBundle][Routing] Remove remaining deprecations| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MITFollows#51483, I took `Annotation*Loader` from 7.0 to update `Attribute*Loader` here with latest changes.Commits-------77f6efc [FrameworkBundle][Routing] Remove remaining deprecations
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull requestOct 18, 2023
… (alexandre-daubois)This PR was merged into the 7.0 branch.Discussion----------[FrameworkBundle][Routing] Remove remaining deprecations| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | -| License       | MITFollowssymfony/symfony#51483, I took `Annotation*Loader` from 7.0 to update `Attribute*Loader` here with latest changes.Commits-------77f6efc601 [FrameworkBundle][Routing] Remove remaining deprecations
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@chalasrchalasrchalasr requested changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@fancywebfancywebfancyweb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DeprecationFrameworkBundleRouting❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

6 participants

@alexandre-daubois@fancyweb@nicolas-grekas@derrabus@chalasr@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp