NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Process] Fix bug where $this->callback is never null, resulting in bad argument#51478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromweaverryan:process-fix-pipes-read-support-regression

Oct 16, 2023

Merged

[Process] Fix bug where $this->callback is never null, resulting in bad argument#51478

fabpot merged 1 commit intosymfony:6.4fromweaverryan:process-fix-pipes-read-support-regression

Oct 16, 2023

Conversation

Copy link

Member

weaverryan commentedAug 24, 2023

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	None
License	MIT
Doc PR	Not needed

Hi!

Caused by#51068 - by the time$this->getDescriptors() is called,$this->callback is ALWAYS a callable thanks to$this->callback = $this->buildCallback($callback).

Previously, there was a separatehasCallback property that handled this logic. I chose to NOT re-add that because it was only needed ingetDescriptors() and that is only called from this one place: easier to pass$hasCallback as an argument.

Caught by the symfony/ux test suite ❤️

Cheers!