#51425 deprecated theAnnotationLoader class and its replacement already does not accept an annotation reader anymore. Thus, the deprecation of the constructor parameter is redundant, which is why I propose to take it back.

cc@alexandre-daubois

[Validator] Un-deprecate passing an annotation reader to AnnotationLo…

4fa1d32

…ader

carsonbot added Status: Needs Review Feature Validator labels

Aug 22, 2023

carsonbot added this to the6.4 milestone

Aug 22, 2023

nicolas-grekas approved these changes

Aug 22, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 22, 2023

stof reviewed

Aug 22, 2023

View reviewed changes

src/Symfony/Component/Validator/Tests/Mapping/Loader/AttributeLoaderTest.php

		protectedfunctioncreateAnnotationLoader():AnnotationLoader
		{
		returnnewAnnotationLoader();
		returnnewAttributeLoader();

Copy link

Member

stofAug 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This does not match the return type

Copy link

MemberAuthor

derrabusAug 22, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It does,AttributeLoader extendsAnnotationLoader. This class (AttributeLoaderTest) has two child classes which override this method. I have to keep the return type wide, otherwise I would break those child classes.

Copy link

Member

alexandre-daubois commentedAug 22, 2023•
edited
Loading

Just for the record, I'm working on deprecating the serializer's AnnotationLoader too (and replacing it by an AttributeLoader). 🙂 I'll include this same undeprecation in the coming PR