Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] [Smtp] Add DSN parampeer_fingerprint for fingerprint verification#51450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromxdavidwu:mailer-smtp-peer-fingerprint
Aug 30, 2023

Conversation

@xdavidwu
Copy link
Contributor

@xdavidwuxdavidwu commentedAug 22, 2023•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets-
LicenseMIT
Doc PRsymfony/symfony-docs#18778

This allows a more secure TLS connection for SMTP on even self-signed certificates, by verifying certificate fingerprint.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbotcarsonbot changed the title[Mailer][Smtp] Add DSN parampeer_fingerprint for fingerprint verif…[Mailer] [Smtp] Add DSN parampeer_fingerprint for fingerprint verif…Aug 22, 2023
xdavidwu added a commit to xdavidwu/symfony-docs that referenced this pull requestAug 22, 2023
xdavidwu added a commit to xdavidwu/symfony-docs that referenced this pull requestAug 22, 2023
@nicolas-grekasnicolas-grekas changed the title[Mailer] [Smtp] Add DSN parampeer_fingerprint for fingerprint verif…[Mailer] [Smtp] Add DSN parampeer_fingerprint for fingerprint verificationAug 23, 2023
@xdavidwuxdavidwuforce-pushed themailer-smtp-peer-fingerprint branch fromd6d7635 toa9d8431CompareAugust 24, 2023 04:09
@fabpot
Copy link
Member

Thank you@xdavidwu.

@fabpotfabpot merged commitdbd7747 intosymfony:6.4Aug 30, 2023
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestSep 28, 2023
…ingerprint verification (xdavidwu)This PR was merged into the 6.4 branch.Discussion----------[Mailer] [Smtp] Add DSN param `peer_fingerprint` for fingerprint verificationRefs*symfony/symfony#51450Commits-------dbfcbb1 [Mailer][Smtp] Add DSN param `peer_fingerprint` for fingerprint verification
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@mtarldmtarldmtarld approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@xdavidwu@carsonbot@fabpot@nicolas-grekas@mtarld
[8]ページ先頭
©2009-2025 Movatter.jp