Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Do not callUserBadge->setUserLoader(UserProvider...) when the loader is already provided byAccessTokenHandler implementation#51447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@kaznovac
Copy link
Contributor

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#51446
LicenseMIT
Doc PRN/A

restore previous behavior to fix the linked issue

99a35f0#diff-de9707bb338188f62878f2ebd42e7a7bf9547f6d0bf07a4fcd9c386c263c601bL62-R62

…en the loader is already provided by `AccessTokenHandler` implementation
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@kaznovackaznovac changed the base branch from6.4 to6.3August 21, 2023 23:30
@kaznovac
Copy link
ContributorAuthor

failure ofUnit Tests / Unit Tests (8.1) (pull_request) is related to the PR code
https://github.com/symfony/symfony/actions/runs/5931656918/job/16083952927?pr=51447#step:8:2818

the rest seem unrelated

@guillaumesmo
Copy link
Contributor

I believe this has already been fixed by#51104

kaznovac reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[Security]UserBadge->userLoader always overwritten byAccessTokenAuthenticator->userProvider when later is set regardless of former

3 participants

@kaznovac@carsonbot@guillaumesmo
[8]ページ先頭
©2009-2025 Movatter.jp