NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[FrameworkBundle] Remove config deprecations#51428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:7.0fromalexandre-daubois:options-default-values

Aug 23, 2023

Merged

[FrameworkBundle] Remove config deprecations#51428

nicolas-grekas merged 1 commit intosymfony:7.0fromalexandre-daubois:options-default-values

Aug 23, 2023

Conversation

Copy link

Member

alexandre-daubois commentedAug 19, 2023

Q	A
Branch?	7.0
Bug fix?	no
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	Todo

Follow-up of:

carsonbot added Status: Needs Review FrameworkBundle labels

Aug 19, 2023

carsonbot added this to the7.0 milestone

Aug 19, 2023

nicolas-grekas reviewed

Aug 21, 2023

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php OutdatedShow resolvedHide resolved

alexandre-daubois mentioned this pull request

Aug 21, 2023

[FrameworkBundle] Deprecate not setting bothframework.session.save_path andframework.session.handler_id at the same time#51438

Merged

nicolas-grekas added a commit that referenced this pull request

Aug 21, 2023

minor#51438[FrameworkBundle] Deprecate not setting both `framework.…

060ee11

…session.save_path` and `framework.session.handler_id` at the same time (alexandre-daubois)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] Deprecate not setting both `framework.session.save_path` and `framework.session.handler_id` at the same time| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | yes| Tickets       | -| License       | MIT| Doc PR        | -This is the follow-up of#51428 (comment)Commits-------85faa69 [FrameworkBundle] Deprecate not setting both `framework.session.save_path` and `framework.session.handler_id` at the same time

GromNaN reviewed

Aug 21, 2023

View reviewed changes

UPGRADE-7.0.md OutdatedShow resolvedHide resolved

alexandre-daubois force-pushed theoptions-default-values branch 2 times, most recently frome98b2db to9a05727Compare

August 21, 2023 12:44

nicolas-grekas reviewed

Aug 21, 2023

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

		$v['session'] += [
		'cookie_samesite' =>null,
		'handler_id' =>'session.handler.native_file',
		'save_path' =>'%kernel.cache_dir%/sessions',

Copy link

Member

nicolas-grekasAug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

whenhandler_id is non-null, save_path should still default to%kernel.cache_dir%/sessions, how can we deal with that?

Copy link

MemberAuthor

alexandre-dauboisAug 21, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I updated the condition:

if (!\array_key_exists('handler_id',$v['session'])) {$v['session']['handler_id'] =$v['session']['save_path'] ?'session.handler.native_file' :null;}elseif (null !==$v['session']['handler_id']) {$v['session']['save_path'] ??='%kernel.cache_dir%/sessions';}

Also updated changelog toMake the framework.session.save_path config option default to %kernel.cache_dir%/sessions if framework.session.handler_id is set or null otherwise