Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle][Validator] Deprecate annotation occurrences#51425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedAug 18, 2023•
edited by nicolas-grekas
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsPart of#51381
LicenseMIT
Doc PR-
  • Deprecateframework.validation.enable_annotations in favor offramework.validation.enable_attributes
  • Deprecateframework.serializer.enable_annotations in favor of useframework.serializer.enable_attributes
  • DeprecateValidatorBuilder::enableAnnotationMapping() in favor ofValidatorBuilder::enableAttributeMapping()
  • DeprecateValidatorBuilder::disableAnnotationMapping() in favor ofValidatorBuilder::disableAttributeMapping()
  • DeprecateAnnotationLoader in favor ofAttributeLoader

derrabus reacted with rocket emoji
@stof
Copy link
Member

This should be in the same PR than#51426 instead of being a separate PR IMO, as this is about the FrameworkBundle semantic configuration related to the same change.
We don't require each PR to change only one of the packages. It is actually quite the opposite. The main reason to have a mono-repo is to allow to have one change spanning multiple packages.

@alexandre-dauboisalexandre-dauboisforce-pushed thedeprecate-enable-annotations branch 3 times, most recently from97dc60e to0bd8e1fCompareAugust 18, 2023 14:01
@alexandre-dauboisalexandre-dauboisforce-pushed thedeprecate-enable-annotations branch 3 times, most recently from89a4e3c to1723d35CompareAugust 18, 2023 14:32
@alexandre-daubois
Copy link
MemberAuthor

Addressed your comments@derrabus, thank you!

@derrabus
Copy link
Member

Thank you@alexandre-daubois.

@alexandre-daubois
Copy link
MemberAuthor

Working on the clean-up 👍

derrabus reacted with thumbs up emoji

@alexandre-dauboisalexandre-daubois deleted the deprecate-enable-annotations branchAugust 22, 2023 13:30
derrabus added a commit that referenced this pull requestAug 23, 2023
…to AnnotationLoader (derrabus)This PR was merged into the 6.4 branch.Discussion----------[Validator] Un-deprecate passing an annotation reader to AnnotationLoader| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | Follow-up to#51425| License       | MIT| Doc PR        | N/A#51425 deprecated the `AnnotationLoader` class and its replacement already does not accept an annotation reader anymore. Thus, the deprecation of the constructor parameter is redundant, which is why I propose to take it back.cc `@alexandre`-dauboisCommits-------4fa1d32 [Validator] Un-deprecate passing an annotation reader to AnnotationLoader
nicolas-grekas added a commit that referenced this pull requestAug 23, 2023
…ns (alexandre-daubois)This PR was merged into the 7.0 branch.Discussion----------[FrameworkBundle][Validator] Remove remaining deprecations| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | -| License       | MIT| Doc PR        |symfony/symfony-docs#18781Follow-up of#51425Commits-------6e8cab7 [FrameworkBundle][Validator] Remove remaining deprecations
This was referencedOct 21, 2023
@lyrixx
Copy link
Member

see#52287

@alexandre-daubois
Copy link
MemberAuthor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@derrabusderrabusderrabus approved these changes

@mtarldmtarldmtarld approved these changes

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

7 participants

@alexandre-daubois@stof@derrabus@lyrixx@nicolas-grekas@mtarld@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp