Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Fix missing Request in RequestStack for StreamedResponse#51396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromnicolas-grekas:DaDeather/fix-httpkernel-issue-46743Aug 16, 2023
Merged
[HttpKernel] Fix missing Request in RequestStack for StreamedResponse#51396
nicolas-grekas merged 1 commit intosymfony:6.3fromnicolas-grekas:DaDeather/fix-httpkernel-issue-46743Aug 16, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a29c535 toca1c40eComparederrabus approved these changesAug 16, 2023
alexander-schranz approved these changesAug 16, 2023
Contributor
alexander-schranz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks fine from my side.
MemberAuthor
nicolas-grekas commentedAug 16, 2023
Thank you Ismail Turan. |
Contributor
DaDeather commentedAug 16, 2023
Sure happy to help! |
Merged
nicolas-grekas added a commit that referenced this pull requestOct 12, 2023
…` (elementaire)This PR was merged into the 6.3 branch.Discussion----------[HttpKernel] Handle nullable callback of `StreamedResponse`| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | -| License | MITThis PR fixes a bug introduced by#51396. Having a callback in `StreamResponsed` is not a mandatory by design.So the method `getCallback` must check it like `sendContent` does.When we are dealing with cacheable ressource, only headers are sent from `StreamResponsed`, for example:```php#[Route(path: '/download')]public function download(Request $request): StreamedResponse{ // Get the last modified of a file. $lastModified = \DateTime::createFromFormat('d/m/Y H:i:s', '10/10/2023 13:22:00'); $response = (new StreamedResponse())->setLastModified($lastModified); if ($response->isNotModified($request)) { return $response; } // Get the stream of a file and attach it to the callback. // ... return $response;}````HttpKernel` class have to handle it else if you obtain `HTTP 500` with message `Value of type null is not callable`.cc `@nicolas`-grekasCommits-------66648c5 [HttpKernel] Handle nullable callback of StreamedResponse
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to#51139 by@DaDeather, see discussion there.