NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Serializer] Fix deserializing of nested snake_case attributes using CamelCaseToSnakeCaseNameConverter#51394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

Victor-Truhanovich wants to merge1 commit intosymfony:6.3fromVictor-Truhanovich:fixed_snake_case_nested_attributes_denormalize

Closed

[Serializer] Fix deserializing of nested snake_case attributes using CamelCaseToSnakeCaseNameConverter#51394

Victor-Truhanovich wants to merge1 commit intosymfony:6.3fromVictor-Truhanovich:fixed_snake_case_nested_attributes_denormalize

Conversation

Copy link

Contributor

Victor-Truhanovich commentedAug 15, 2023•
edited
Loading

Q	A
Branch?	6.3
Bug fix?	yes
New feature?	no
Deprecations?	no
License	MIT

It was not possible to deserialize nested attributes using CamelCaseToSnakeCaseNameConverter

Example

class Foo {    #[SerializedPath("[one][two_three]")]public$fooBar;}$factory =newClassMetadataFactory(newAnnotationLoader(newAnnotationReader()));$normalizer =newObjectNormalizer($factory,newCamelCaseToSnakeCaseNameConverter());$serializer =newSerializer([$normalizer]);$data = ['one' => ['two_three' =>'fooBar',    ],];$foo =$serializer->denormalize($data, Foo::class,'any');

Victor-Truhanovich requested a review fromdunglas as acode owner

August 15, 2023 23:55

carsonbot added Status: Needs Review Bug Serializer labels

Aug 15, 2023

Copy link

carsonbot commentedAug 15, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link

carsonbot commentedAug 15, 2023

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update thePR base branch to target one of these branches instead? 5.4, 6.3, 6.4, 7.0.

Cheers!

Carsonbot