Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[HttpKernel] Revert #45476 to fix missingRequest inRequestStack forStreamedResponse#51391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[HttpKernel] Revert #45476 to fix missingRequest inRequestStack forStreamedResponse#51391
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… purpose anymore"This reverts commitee61774.
alexander-schranz commentedAug 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Reverting#45476 will break streamedresponses for other Runtimes like Roadrunner, Swoole (php-runtime/runtime#115), is there any possibility todo this only when specific Addition: The problem also is that it would behave differently between Roadrunner, Swoole, now as they could then still run into#46743 where this listener is required to be disabled. I understand@derrabus concern about#51139 but to have full support for such runtimes I don't see another way then make HttpKernel aware of a Response class specially it already has dependency to HttpFoundation. |
nicolas-grekas commentedAug 16, 2023
Thanks for the reminder@alexander-schranz |
derrabus commentedAug 16, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The other way would be to document that the request stack is empty when Note that the breaking change was to un-wire the deprecated listener which has happened without prior deprecation in a minor release. We could wire it again, but make it opt-out by introducing a config flag into FrameworkBundle. Yeah, I know how we don't like those. |
nicolas-grekas commentedAug 16, 2023
This ship has sailed IMHO. Also it's very hard to deal with, because any services can be used in that callback. I think#51396 is pragmatic and makes sense also. |
derrabus commentedAug 16, 2023
LGTM. |
Revert#45476 and add test to ensure
Requestavailability while usingStreamedResponsecallback.