Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Console] fix section output when multiples section with max height#51355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
1ffffc2 to4fe2c53Compare| $expected .='Two'.\PHP_EOL.'Three'.\PHP_EOL.'Four'.\PHP_EOL; | ||
| rewind($this->stream); | ||
| $this->assertEquals(escapeshellcmd($expected),escapeshellcmd(stream_get_contents($this->stream))); |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
escallesshellcmd is intended here, it's way better to debug output with this, as we can properly see escaped character when there is a failure :
4fe2c53 to28e9da6Comparelyrixx approved these changesAug 11, 2023
Member
lyrixx left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Works great! Thanks!
console-section.webm
stof approved these changesAug 11, 2023
fabpot approved these changesAug 12, 2023
Member
fabpot commentedAug 12, 2023
Thank you@joelwurtz. |
Merged
renovatebot added a commit to Lendable/composer-license-checker that referenced this pull requestAug 26, 2023
[](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [symfony/console](https://symfony.com)([source](https://togithub.com/symfony/console)) | require | patch |`6.3.2` -> `6.3.4` || [symfony/process](https://symfony.com)([source](https://togithub.com/symfony/process)) | require | patch |`6.3.2` -> `6.3.4` |---### Release Notes<details><summary>symfony/console (symfony/console)</summary>### [`v6.3.4`](https://togithub.com/symfony/console/releases/tag/v6.3.4)[CompareSource](https://togithub.com/symfony/console/compare/v6.3.2...v6.3.4)**Changelog**(symfony/console@v6.3.3...v6.3.4)- bug[symfony/symfony#51378](https://togithub.com/symfony/symfony/issues/51378)\[Console] avoid multiple new line when message already ends with a newline in section output([@​joelwurtz](https://togithub.com/joelwurtz))- bug[symfony/symfony#51223](https://togithub.com/symfony/symfony/issues/51223)\[Console] Fix linewraps in `OutputFormatter` (@​maxbeckers)- bug[symfony/symfony#51355](https://togithub.com/symfony/symfony/issues/51355)\[Console] fix section output when multiples section with max height([@​joelwurtz](https://togithub.com/joelwurtz))</details><details><summary>symfony/process (symfony/process)</summary>###[`v6.3.4`](https://togithub.com/symfony/process/compare/v6.3.2...v6.3.4)[CompareSource](https://togithub.com/symfony/process/compare/v6.3.2...v6.3.4)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/Lendable/composer-license-checker).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
%5d(https%3a%2f%2frenovatebot.com){kind=link}
1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This pr does notfix#35012
However it fixes the second script wrote by@lyrixx (#35012 (comment)) with fiber and parallel output.
In short when there was multiple sections with max height, it was not taking into account the max height of other sections when doing a full rewrite, leading to erase more lines than intended.