Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AssetMapper] Add command to download missing downloaded packages#51351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@jmsche
Copy link
Contributor

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRNone yet

Hi, this PR adds aimportmap:install command to download all packages marked as downloaded in theimpormap.php file that are missing on filesystem.

To quote@weaverryan:

the intention is to allow devs to not commitassets/vendor/, which means that this is a command you’ll run during deploy and your teammates will run

Jibbarth reacted with heart emojiJibbarth reacted with rocket emoji
@jmsche
Copy link
ContributorAuthor

AppVeyor failure unrelated.
I guess Unit Tests 8.2 fail because this branch is not merged in 7.0 yet 😄
Not sure about Psalm, I think it's okay.

@jmsche
Copy link
ContributorAuthor

Updated PR with rewording, thrown exception is no version found & added a test :)

@nicolas-grekasnicolas-grekasforce-pushed theasset-mapper-download-missing branch from989e725 toa82a429CompareAugust 23, 2023 20:08
@nicolas-grekas
Copy link
Member

Thank you@jmsche.

@nicolas-grekasnicolas-grekas merged commitc24906f intosymfony:6.4Aug 23, 2023
@jmschejmsche deleted the asset-mapper-download-missing branchAugust 24, 2023 07:10
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull requestAug 28, 2023
…jmsche)This PR was merged into the 6.4 branch.Discussion----------[AssetMapper] Add docs for `importmap:install` commandHi, this PR adds docs for the new `importmap:install` command added bysymfony/symfony#51351.Commits-------978f1dc [AssetMapper] Add docs for the importmap:install command
fabpot added a commit that referenced this pull requestAug 30, 2023
… not found (jmsche)This PR was merged into the 6.4 branch.Discussion----------[AssetMapper] Improve message when a downloaded asset is not found| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AThis PR improves the exception message introduced in#51337 by mentioning the command introduced in#51351.Commits-------69cae6f [AssetMapper] Improve exception message when a downloaded asset is not found
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasdunglas approved these changes

@weaverryanweaverryanweaverryan approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@jmsche@nicolas-grekas@dunglas@weaverryan@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp