Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Security] Prevent creating session in stateless firewalls#51350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
chalasr merged 1 commit intosymfony:6.3fromSeb33300:6.3-stateless
Aug 25, 2023

Conversation

@Seb33300
Copy link
Contributor

@Seb33300Seb33300 commentedAug 11, 2023•
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#51319
LicenseMIT
Doc PR

Please check related issue for details.

Same as#51320 with@chalasr suggestion:#51320 (comment)

jaapromijn and stloyd reacted with thumbs up emoji
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link
Member

@chalasrchalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add test cases with_stateless => true for both success and failure handlers to prevent regressions

@Seb33300
Copy link
ContributorAuthor

Please add test cases with_stateless => true for both success and failure handlers to prevent regressions

@chalasr tests added

@stloyd
Copy link
Contributor

@wouterj@chalasr Could you have a second look at this?

I can confirm the fix on HWIOAuthBundle. Before:

PHPUnit 9.6.11 by Sebastian Bergmann and contributors.Testing /Users/stloyd/Documents/HWIOAuthBundle/tests/Functional<!-- Session was used while the request was declared stateless. (500 Internal Server Error) -->// error page printed

After:

PHPUnit 9.6.11 by Sebastian Bergmann and contributors.Testing /Users/stloyd/Documents/HWIOAuthBundle/tests/FunctionalTime: 00:00.090, Memory: 18.00 MBOK (1 test, 4 assertions)
Seb33300 reacted with heart emoji

@stloyd
Copy link
Contributor

@fabpot /@nicolas-grekas or anyone else can check this fix? I would love to have it in near 6.3 release

@Seb33300
Copy link
ContributorAuthor

August is usually a period of holidays in europe so@chalasr and@wouterj may not be available this week.
Let's see next week :)

stloyd reacted with thumbs up emoji

@chalasr
Copy link
Member

Thank you@Seb33300.

stloyd reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof approved these changes

@mtarldmtarldmtarld approved these changes

@chalasrchalasrchalasr approved these changes

@wouterjwouterjAwaiting requested review from wouterj

+1 more reviewer

@stloydstloydstloyd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

Session created by default handlers on stateless firewalls

6 participants

@Seb33300@carsonbot@stloyd@chalasr@stof@mtarld
[8]ページ先頭
©2009-2025 Movatter.jp