Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Notifier] Add GoIP bridge#51349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@ahmedghanem00
Copy link
Contributor

@ahmedghanem00ahmedghanem00 commentedAug 10, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PRsymfony/symfony-docs#18742
Recipessymfony/recipes#1233

GoIP is a GSM Gateway/SIM-Hub that provides the ability to send SMS messages over the network. I think it would be useful to add an integration for it with the Symfony Notifier

Copy link
Contributor

@OskarStarkOskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for providing this new bridge. I would love to see a PR against symfony/symfony-docs and symfony/recipes 👍

@fabpot
Copy link
Member

@ahmedghanem00 Can you rebase to get rid of the merge commit?

@ahmedghanem00
Copy link
ContributorAuthor

ahmedghanem00 commentedAug 12, 2023•
edited
Loading

@fabpot I think this is done now

@fabpot
Copy link
Member

Thank you@ahmedghanem00.

ahmedghanem00 reacted with thumbs up emoji

@fabpotfabpot closed thisAug 12, 2023
@fabpotfabpotforce-pushed thefeature/goip-notifier branch from8075d08 to066d0f8CompareAugust 12, 2023 12:35
fabpot added a commit that referenced this pull requestAug 12, 2023
This PR was squashed before being merged into the 6.4 branch.Discussion----------[Notifier] Add GoIP bridge| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       || License       | MIT| Doc PR        |symfony/symfony-docs#18742| Recipes       |symfony/recipes#1233GoIP is a GSM Gateway/SIM-Hub that provides the ability to send SMS messages over the network. I think it would be useful to add an integration for it with the Symfony NotifierCommits-------066d0f8 [Notifier] Add GoIP bridge
@ahmedghanem00ahmedghanem00 deleted the feature/goip-notifier branchAugust 12, 2023 17:15
@ahmedghanem00ahmedghanem00 restored the feature/goip-notifier branchAugust 12, 2023 17:16
@ahmedghanem00ahmedghanem00 deleted the feature/goip-notifier branchAugust 12, 2023 17:16
@ahmedghanem00
Copy link
ContributorAuthor

@fabpot Thanks, Just a small wondering about why the status of the PR is closed instead of merged like others 😆

@fabpot
Copy link
Member

That’s a race condition in the order of the API calls. No worries, it was merged like any other PR.

ahmedghanem00 reacted with heart emoji

OskarStark added a commit to symfony/symfony-docs that referenced this pull requestAug 14, 2023
This PR was merged into the 6.4 branch.Discussion----------[Notifier] Add GoIP bridgeTo follow-up withsymfony/symfony#51349Commits-------96ebe06 [Notifier] Add GoIP bridge
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@ahmedghanem00@fabpot@OskarStark@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp