Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AssetMapper] Improve the error message when a downloaded file is missing#51337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@jmsche
Copy link
Contributor

@jmschejmsche commentedAug 10, 2023•
edited by nicolas-grekas
Loading

QA
Branch?6.3
Bug fix?no
New feature?no
Deprecations?no
TicketsN/A
LicenseMIT
Doc PRN/A

When a file downloaded using theimportmap:require [packageName] --download command is missing, the error message is this one:

The asset "vendor/@hotwired/stimulus.js" mentioned in "importmap.php" cannot be found in any asset map paths.

This PR slightly improves the error message to explain how it can be fixed:

The "vendor/@hotwired/stimulus.js" downloaded asset is missing. Run "php bin/console importmap:require @hotwired/stimulus --download".

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@jmschejmsche changed the base branch from6.4 to6.3August 10, 2023 08:21
@jmsche
Copy link
ContributorAuthor

Hmm the error spotted by fabbot can't be applied as is. Should I put backticks around the command instead?

AppVeyor, Integration (8.1) & Unit Tests (8.1) failures are unrelated to this PR.

@weaverryan
Copy link
Member

Hmm the error spotted by fabbot can't be applied as is

Couldn't we apply it? It is suggesting:

Run "php bin/console importmap:require "%s" --download"

Are you worried about how the the" around the entire command and. the extra" around the argument look? If so, I think it's ok: the fullbin/console command is legal.

@stof
Copy link
Member

Anyway, the command will bebetter with quotes arounds the package name. Depending on the package name, it might require quoting to make the command valid.

@jmsche
Copy link
ContributorAuthor

Added quotes around the package name :)

Copy link
Member

@weaverryanweaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

After merge, the message should be updated in#51351 for the new command there.

@jmsche
Copy link
ContributorAuthor

@weaverryan will be done :)

@nicolas-grekasnicolas-grekas changed the title[AssetMapper] Improve the error message when a downloaded file is mis…[AssetMapper] Improve the error message when a downloaded file is missingAug 23, 2023
@nicolas-grekasnicolas-grekas modified the milestones:6.4,6.3Aug 23, 2023
@nicolas-grekasnicolas-grekasforce-pushed theimprove-importmap-missing-downloaded-file-error-message branch from2c9834a to06fb6feCompareAugust 23, 2023 20:11
@nicolas-grekas
Copy link
Member

Thank you@jmsche.

@nicolas-grekasnicolas-grekas merged commit897a054 intosymfony:6.3Aug 23, 2023
@nicolas-grekas
Copy link
Member

Follow up PR welcome

@jmsche
Copy link
ContributorAuthor

Sure, I'll update the error message with a PR for the 6.4 branch tomorrow :)

@jmschejmsche deleted the improve-importmap-missing-downloaded-file-error-message branchAugust 24, 2023 07:11
fabpot added a commit that referenced this pull requestAug 30, 2023
… not found (jmsche)This PR was merged into the 6.4 branch.Discussion----------[AssetMapper] Improve message when a downloaded asset is not found| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       | N/A| License       | MIT| Doc PR        | N/AThis PR improves the exception message introduced in#51337 by mentioning the command introduced in#51351.Commits-------69cae6f [AssetMapper] Improve exception message when a downloaded asset is not found
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@weaverryanweaverryanweaverryan approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.3

Development

Successfully merging this pull request may close these issues.

5 participants

@jmsche@carsonbot@weaverryan@stof@nicolas-grekas
[8]ページ先頭
©2009-2025 Movatter.jp