Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[SecurityBundle] Deprecate therequire_previous_session config option#51332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
alamirault wants to merge0 commits intosymfony:6.4fromalamirault:feature/51318-deprecate-require-previous-session
Closed
[SecurityBundle] Deprecate therequire_previous_session config option#51332
alamirault wants to merge0 commits intosymfony:6.4fromalamirault:feature/51318-deprecate-require-previous-session
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
d20b828 to2afa2f2Comparewouterj approved these changesAug 9, 2023
| if ('require_previous_session' ===$name) { | ||
| $builder | ||
| ->booleanNode($name) | ||
| ->setDeprecated('symfony/security-bundle','6.4','Option "%node%" at "%path%" is deprecated. It does nothing and will be removed in version 7.0.') |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Suggested change
| ->setDeprecated('symfony/security-bundle','6.4','Option "%node%" at "%path%" is deprecated. It does nothing andwill be removed in version 7.0.') | |
| ->setDeprecated('symfony/security-bundle','6.4','Option "%node%" at "%path%" is deprecated itwill be removed in version 7.0. Setting it has no effect anymore.') |
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I took the same message thanreset_on_message on 6.1
But indeed, your suggestion is better !
It's applied
fabpot approved these changesAug 11, 2023
Member
fabpot commentedAug 11, 2023
Thank you@alamirault. |
fabpot added a commit that referenced this pull requestAug 11, 2023
…on` config option (alamirault)This PR was squashed before being merged into the 6.4 branch.Discussion----------[SecurityBundle] Deprecate the `require_previous_session` config option| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets |Fix#51318 <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->This PR deprecate the `require_previous_session` config optionRemove is done in#51333 on 7.0Commits-------f92b0fc [SecurityBundle] Deprecate the `require_previous_session` config option
c590d2d tof92b0fcComparefabpot added a commit that referenced this pull requestAug 11, 2023
…onfig option (alamirault)This PR was squashed before being merged into the 7.0 branch.Discussion----------[SecurityBundle] Remove the `require_previous_session` config option| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->To merge after#51332 is merged on 6.4 which deprecate config option. This PR remove last usage of optionCommits-------6372df4 [SecurityBundle] Remove the `require_previous_session` config option
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR deprecate the
require_previous_sessionconfig optionRemove is done in#51333 on 7.0