Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] add handler description as array key toHandlerFailedException::getWrappedExceptions()#51331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can this be tested somehow?
src/Symfony/Component/Messenger/Exception/HandlerFailedException.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Messenger/Exception/HandlerFailedException.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
97e3fea to61a5a06Comparekbond commentedSep 20, 2023
Test added. |
src/Symfony/Component/Messenger/Tests/Middleware/HandleMessageMiddlewareTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
fabpot commentedOct 1, 2023
Should be rebased (see#51653) |
61a5a06 to84abc0dComparekbond commentedOct 2, 2023
Rebased. |
3e34ef0 to7c7fb54Comparekbond commentedOct 2, 2023
Psalm errors fixed. |
src/Symfony/Component/Messenger/Tests/Exception/HandlerFailedExceptionTest.phpShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
7c7fb54 toc2650c1Comparechalasr commentedOct 2, 2023
What about reverting the changes made to the now deprecated |
kbond commentedOct 2, 2023
You mean throw an Another thing, it would be nice if |
chalasr commentedOct 2, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
It's probably not a big deal here but yes, we usually avoid changing deprecated code paths.
I think it would be possible to use |
c2650c1 to5e7bb97Comparekbond commentedOct 23, 2023
@chalasr, I've made this change.
I'm going to leave this off of this PR because of the possible edge cases you describe. This can be revisited later if desired. |
5e7bb97 to06a697cComparesrc/Symfony/Component/Messenger/Exception/WrappedExceptionsInterface.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
06a697c todcc788dComparesrc/Symfony/Component/Messenger/Exception/HandlerFailedException.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
dcc788d to9e67f29CompareHandlerFailedException::getNestedExceptions()HandlerFailedException::getWrappedExceptions()src/Symfony/Component/Messenger/Exception/HandlerFailedException.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
…eption::getWrappedExceptions()`
5be2a1e to275c3afComparenicolas-grekas commentedOct 25, 2023
Thank you@kbond. |
Currently, when looking at
HandlerFailedExceptionto see what exceptions were thrown for a message, you can't see what handler caused the exception.