Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Messenger] Always return bool from messenger amqp connection nack#51328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Danielss89
Copy link
Contributor

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Ticketsno
LicenseMIT

This PR fixes the nack method return value of amqp connection. With php-amqp 2 it needs to be a boolean. Another PR fixed the ack method.

@carsonbotcarsonbot added this to the5.4 milestoneAug 9, 2023
@Danielss89Danielss89 changed the titleAlways return bool from messenger amqp conncetion nackAlways return bool from messenger amqp connection nackAug 9, 2023
@carsonbotcarsonbot changed the titleAlways return bool from messenger amqp connection nack[Messenger] Always return bool from messenger amqp connection nackAug 10, 2023
@fabpot
Copy link
Member

Thank you@Danielss89.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@derrabusderrabusderrabus approved these changes

@xabbuhxabbuhxabbuh approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Danielss89@fabpot@derrabus@xabbuh@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp