Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[FrameworkBundle] Deprecate not setting some options#51325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@Jean-Beru
Copy link
Contributor

@Jean-BeruJean-Beru commentedAug 9, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
TicketsFix#51097
LicenseMIT
Doc PR

This PR deprecates not setting 5 options in framework configuration to match the v7.0 recipe:

  • handle_all_throwables which isfalse by default and is set totrue by recipe
  • php_errors.log which use$debug value by default and is set totrue by recipe
  • session.cookie_secure (if session is enabled) which isnull by default and is set toauto by recipe
  • session.cookie_samesite (if session is enabled) which isnull by default and is set tolax by recipe
  • session.handler_id (if session is enabled) which issession.handler.native_file by default and is set tonull by recipe (could besession.handler.native_file ifframework.session.save_path is set)

See#51097.

@carsonbotcarsonbot added this to the6.4 milestoneAug 9, 2023
@Jean-BeruJean-Beruforce-pushed theframework-bundle/deprecate-configuration branch 4 times, most recently from73c3fc6 tob5bba1aCompareAugust 9, 2023 20:40
@nicolas-grekasnicolas-grekasforce-pushed theframework-bundle/deprecate-configuration branch fromb0f411e to7f9998eCompareAugust 17, 2023 15:58
@nicolas-grekas
Copy link
Member

I addressed theremaining issues.

@nicolas-grekas
Copy link
Member

Thank you@Jean-Beru.

@nicolas-grekasnicolas-grekas merged commitd07f17a intosymfony:6.4Aug 17, 2023
@GromNaN
Copy link
Member

I think you can revert most of the changes in the tests in the 7.0 branch now that it has been merged.

@nicolas-grekas
Copy link
Member

Help wanted for the cleanup on 7.0!

alexandre-daubois reacted with thumbs up emoji

nicolas-grekas added a commit that referenced this pull requestAug 23, 2023
…daubois)This PR was merged into the 7.0 branch.Discussion----------[FrameworkBundle] Remove config deprecations| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Tickets       | -| License       | MIT| Doc PR        | TodoFollow-up of:-#51325-#51357Commits-------4fe6f5b [FrameworkBundle] Remove config deprecations
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@wouterjwouterjAwaiting requested review from wouterj

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[RFC] Shrink recipes for v7

5 participants

@Jean-Beru@nicolas-grekas@GromNaN@stof@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp