Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[HttpFoundation] AddQueryParameterRequestMatcher#51324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexandre-daubois
Copy link
Member

@alexandre-dauboisalexandre-daubois commentedAug 9, 2023•
edited by OskarStark
Loading

QA
Branch?7.1
Bug fix?no
New feature?yes
Deprecations?no
TicketsNA
LicenseMIT
Doc PRTodo

We know we need aauthorizationCode query parameter to support a request in our authenticator. We would love to use only theChainRequestMatcher to do so. I'd like to add thisQueryParameterRequestMatcher in order to do the following:

class OurAuthenticatorextends AbstractAuthenticator{publicfunctionsupports(Request$request): ?bool    {return (newChainRequestMatcher([// ...newPathRequestMatcher('/sso/provider'),newQueryParameterRequestMatcher('authorizationCode')        ]))->matches($request);    }// ...}

Which would match the following:/sso/provider?authorizationCode=...

ruudk and stetodd reacted with heart emoji
@norkunas
Copy link
Contributor

norkunas commentedAug 10, 2023•
edited
Loading

While writing github webhook request parser I encountered that they send signature as a header, would it make sense to also addHeaderRequestMatcher to core?

@alexandre-daubois
Copy link
MemberAuthor

That would be a big yes for me, definitely! Gave a try here:#51343

Thank you for the idea, it would be even more powerful with those features!

norkunas and sstok reacted with heart emoji

@alexandre-dauboisalexandre-dauboisforce-pushed thequery-param-request-matcher branch 2 times, most recently from6aec919 to762ae91CompareAugust 17, 2023 09:58
@alexandre-daubois
Copy link
MemberAuthor

Rebased and conflicts fixed

@nicolas-grekasnicolas-grekas modified the milestones:6.4,7.1Nov 15, 2023
@fabpot
Copy link
Member

Thank you@alexandre-daubois.

@fabpotfabpot merged commit3feccf7 intosymfony:7.1Feb 3, 2024
fabpot added a commit that referenced this pull requestFeb 3, 2024
…-daubois)This PR was merged into the 7.1 branch.Discussion----------[HttpFoundation] Add `HeaderRequestMatcher`| Q             | A| ------------- | ---| Branch?       | 7.1| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | _NA_| License       | MIT| Doc PR        | TodoThis a follow up to:-#51324After `@norkunas`' [comment](#51324 (comment))Commits-------62b5a34 [HttpFoundation] Add `HeaderRequestMatcher`
@fabpotfabpot mentioned this pull requestMay 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

7.1

Development

Successfully merging this pull request may close these issues.

6 participants

@alexandre-daubois@norkunas@fabpot@OskarStark@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp