Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[DependencyInjection] fix dump xml with array/object/enum default value#51307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Jean-Beru
Copy link
Contributor

@Jean-BeruJean-Beru commentedAug 8, 2023
edited
Loading

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#48178
LicenseMIT
Doc PR

This PRfixes#48178 when attempting to dump the container in these conditions:

  • The constructor has in its arguments a non-empty array, an object or an enum with a default value
  • A second argument is placed after
  • A third argument is placed after and is using configuration

Example (might be more explicit):

class Foo{publicfunction__construct(array$array = ['a','b','c'],bool$firstOptional =false,bool$secondOptional =false    ) {}}
services:Foo:arguments:secondOptional:true

⚠️ This PR might cause Git conflicts in 6.3 and 6.4 versions. Do I have to create a dedicated PR for these versions ?

@carsonbotcarsonbot added this to the5.4 milestoneAug 8, 2023
@Jean-BeruJean-Beru changed the titlefix(di): dump xml with array/object/enum default value[DependencyInjection] fix dump xml with array/object/enum default valueAug 8, 2023
Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I guess this issue also exists with yaml? Can you please add a test case for it also?

@nicolas-grekas
Copy link
Member

Thank you@Jean-Beru.

@nicolas-grekasnicolas-grekas merged commit997b97b intosymfony:5.4Aug 14, 2023
This was referencedAug 26, 2023
@Jean-BeruJean-Beru deleted the di/48178-fix-xml-dump-5.4 branchJune 5, 2024 08:15
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@Jean-Beru@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp