Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[FrameworkBundle] add missing default-doctrine-dbal-provider cache pool attribute to XSD#51301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@xabbuh
Copy link
Member

QA
Branch?5.4
Bug fix?yes
New feature?no
Deprecations?no
Tickets
LicenseMIT
Doc PR

<xsd:elementname="default-psr6-provider"type="xsd:string"minOccurs="0"maxOccurs="1" />
<xsd:elementname="default-redis-provider"type="xsd:string"minOccurs="0"maxOccurs="1" />
<xsd:elementname="default-memcached-provider"type="xsd:string"minOccurs="0"maxOccurs="1" />
<xsd:elementname="default-doctrine-dbal-provider"type="xsd:string"minOccurs="0"maxOccurs="1" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this should be an attribute, not an element, to match our XML conventions. The otherxsd:string elements that cannot occur multiple times should have been attributes too, and we already added them as attributes when documenting the XML config and finding this out. So I suggest that new settings are added only as attribute to avoid continuing the non-conventional format.

And what is the difference betweendefault-doctrine-dbal-provider anddefault-doctrine-provider ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I favor consistency on this one.

And what is the difference between default-doctrine-dbal-provider and default-doctrine-provider ?

default-doctrine-provider should have been nameddefault-doctrine-cache-provider, it's using an adapter to doctrine/cache

@nicolas-grekas
Copy link
Member

Thank you@xabbuh.

@nicolas-grekasnicolas-grekas merged commit2c8e5fd intosymfony:5.4Aug 8, 2023
@xabbuhxabbuh deleted the default-dbal-provider-xsd branchAugust 8, 2023 11:19
nicolas-grekas added a commit that referenced this pull requestAug 8, 2023
…to XML attribute (xabbuh)This PR was merged into the 5.4 branch.Discussion----------[FrameworkBundle] change default doctrine DBAL provider to XML attribute| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | no| New feature?  | no| Deprecations? | no| Tickets       |Fix#51301 (comment)| License       | MIT| Doc PR        |Commits-------e8a2e86 change default doctrine DBAL provider to XML attribute
This was referencedAug 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

@stofstofstof left review comments

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@xabbuh@nicolas-grekas@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp