Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Mailer] update Brevo SMTP host#51295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
bastien-wink wants to merge1 commit intosymfony:6.3fromWink-dev:6.3
Closed

Conversation

@bastien-wink
Copy link
Contributor

@bastien-winkbastien-wink commentedAug 6, 2023
edited
Loading

QA
Branch?6.3
Bug fix?yes
New feature?no
Deprecations?no
TicketsFix#51118
LicenseMIT

Backporting#51119 into 6.3.

Seehttps://developers.brevo.com/docs/changes-in-smtp-relay-address
We don't know the termination date for the legacy sendinblue SMTP, it's safer to update it.

thomas2411 reacted with heart emoji
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@fabpot
Copy link
Member

Thank you@bastien-wink.

fabpot added a commit that referenced this pull requestAug 8, 2023
This PR was submitted for the 6.3 branch but it was merged into the 5.4 branch instead.Discussion----------[Mailer] update Brevo SMTP host| Q             | A| ------------- | ---| Branch?       | 6.3| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |Fix#51118| License       | MITBackporting#51119 into 6.3.Seehttps://developers.brevo.com/docs/changes-in-smtp-relay-addressWe don't know the termination date for the legacy sendinblue SMTP, it's safer to update it.Commits-------c85892c [Mailer] update Brevo SMTP host
@fabpotfabpot closed thisAug 8, 2023
This was referencedAug 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fabpotfabpotfabpot approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

3 participants

@bastien-wink@carsonbot@fabpot

[8]ページ先頭

©2009-2025 Movatter.jp