Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] update Brevo SMTP host#51295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedAug 6, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedAug 6, 2023
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
fabpot commentedAug 8, 2023
Thank you@bastien-wink. |
This PR was submitted for the 6.3 branch but it was merged into the 5.4 branch instead.Discussion----------[Mailer] update Brevo SMTP host| Q | A| ------------- | ---| Branch? | 6.3| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets |Fix#51118| License | MITBackporting#51119 into 6.3.Seehttps://developers.brevo.com/docs/changes-in-smtp-relay-addressWe don't know the termination date for the legacy sendinblue SMTP, it's safer to update it.Commits-------c85892c [Mailer] update Brevo SMTP host
Uh oh!
There was an error while loading.Please reload this page.
Backporting#51119 into 6.3.
Seehttps://developers.brevo.com/docs/changes-in-smtp-relay-address
We don't know the termination date for the legacy sendinblue SMTP, it's safer to update it.