Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Notifier] Transport possible to have null#51276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromStaffNowa:notifier-transport-null
Oct 2, 2023

Conversation

StaffNowa
Copy link
Contributor

@StaffNowaStaffNowa commentedAug 4, 2023
edited by OskarStark
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
TicketsFix#51236
LicenseMIT

My test example of why I need to have properly transport null

publicfunctiontestSmsSending():void{$date = (new \DateTimeImmutable())->format('Y-m-d');$stateta =newStateta();$stateta->setDate(new \DateTimeImmutable($date));$stateta->setA95(0);$stateta->setDk(0);$this->entityManager->persist($stateta);$this->entityManager->flush();$this->commandTester->execute([], ['verbosity' => OutputInterface::VERBOSITY_DEBUG    ]);$this->commandTester->assertCommandIsSuccessful();$notifierEvent =$this->getNotifierEvent();self::assertEquals(null,$notifierEvent->getMessage()->getTransport());self::assertEquals("+37061234567",$notifierEvent->getMessage()->getRecipientId());self::assertNotificationIsQueued($notifierEvent);self::assertNotificationSubjectContains($notifierEvent->getMessage(),'Company name');self::assertNotificationTransportIsEqual($notifierEvent->getMessage(),null);}

@StaffNowa
Copy link
ContributorAuthor

Double checked my test case, and I see I can validate it as and 'null.'

@fabpot
Copy link
Member

Thank you@StaffNowa.

@fabpotfabpot merged commit96687e3 intosymfony:6.4Oct 2, 2023
@StaffNowaStaffNowa deleted the notifier-transport-null branchOctober 2, 2023 19:09
OskarStark added a commit to OskarStark/symfony that referenced this pull requestOct 3, 2023
nicolas-grekas added a commit that referenced this pull requestOct 3, 2023
This PR was merged into the 6.4 branch.Discussion----------[Notifier] Fix failing testcase| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#51276| License       | MITFollows*#51276Commits-------f7384f4 [Notifier] Fix failing testcase
symfony-splitter pushed a commit to symfony/notifier that referenced this pull requestOct 3, 2023
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

3 participants
@StaffNowa@fabpot@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp