Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[MonologBridge] DeprecateLogger class in favor ofSymfony\Bridge\Monolog\Monolog#51229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lyrixx wants to merge1 commit intosymfony:6.4fromlyrixx:logger-deprecated

Conversation

@lyrixx
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?kind of
Deprecations?yes
Tickets
LicenseMIT
Doc PR

For the record, I imported the new Monolog class in Monolog, and I ran the test suite and it was okay 👍🏼 all green except one failure, but it's amonolog issue I guess

@lyrixx
Copy link
MemberAuthor

Thanks for the review, I pushed a new version

---

* Add native return type to`Logger::clear()` and to`DebugProcessor::clear()`
* Deprecate`Logger` class in favor of`Symfony\Bridge\Monolog\Monolog`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

to me, this new class should not be introduced either.

the removal of the debug loggers should either be implemented using a service configurator or we should make our debug processor itself able to behave like a no-op for environments where we don't want to collect those debug logs.

And the DebugLoggerInterface should be solved by injecting the DebugHandler in the collector instead of the main logger instance (which would be perfectly supported but is not wired this way in MonologBundle).

derrabus reacted with thumbs up emoji

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's first discuss about removing the@final inSeldaek/monolog#1827

Anyone up to do the PR implementing what@stof describes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for being blunt but this looks like a mess to me. You'd get a Monolog class which you cannot even pass to something expecting a Logger instance (which you would right now do if you want to callreset() or smth on it.

Why not inject a DebugHandler in the Logger at runtime when in development for example?

Or worst case if you must extend Logger then go ahead and extend it, I just marked it final because people were extending it and doing crazy shit which then broke with new features. If you know what you are doing it is IMO safe to extend, and it's why it is just a@final and not a properfinal keyword. I don't want to prevent people, but I want to make it clear that it voids the warranty if you do extend.

Maybe it'd be worth layout out what exactly you are trying to solve here, because I am not 100% sure I am up to speed. I'm happy to try and help find a solution, but removing@final is a no go for me right now.

derrabus reacted with thumbs up emoji
@nicolas-grekas
Copy link
Member

Closing in favor of#51284, thanks for pushing this forward.

@lyrixxlyrixx deleted the logger-deprecated branchAugust 5, 2023 12:58
nicolas-grekas added a commit that referenced this pull requestAug 5, 2023
…iring of debug loggers (nicolas-grekas)This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle][HttpKernel][MonologBridge] Revisit wiring of debug loggers| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | no| New feature?  | yes| Deprecations? | yes| Tickets       | -| License       | MIT| Doc PR        | -Replaces#51229Implements the suggestions from `@stof` and `@Seldaek` in#51229 (comment)It turns our we had almost everything available. This is mostly a matter of wiring.* Deprecate class `Symfony\Bridge\Monolog\Logger`* Deprecate `AddDebugLogProcessorPass::configureLogger()`* Add `DebugLoggerConfigurator` to HttpKernel, which wires `DebugProcessor` when desiredBonus:* Add argument `$debug` to HttpKernel's `Logger`* Deprecate `EnableLoggerDebugModePass` in favor of the previousCommits-------8a6a410 [HttpKernel][MonologBridge][FrameworkBundle] Revisit wiring of debug loggers
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@stofstofstof left review comments

+1 more reviewer

@SeldaekSeldaekSeldaek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

5 participants

@lyrixx@nicolas-grekas@Seldaek@stof@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp