$table =new \Symfony\Component\Console\Helper\Table($output);$table    ->setColumnMaxWidth(1,10)    ->setHeaders(['ISBN','Title'])    ->setRows([        ['99921-58-10-7','A really long title that could need multiple lines'],new \Symfony\Component\Console\Helper\TableSeparator(),        ['99921-58-10-7','Â rèälly löng tîtlè thät cöüld nèêd múltîplê línès']    ]);$table->render();

Before

+---------------+------------+| ISBN          | Title      |+---------------+------------+| 99921-58-10-7 | A really l ||               | ong title  ||               | that could ||               | need multi ||               | ple lines  |+---------------+------------+| 99921-58-10-7 | Â rèäll    ||               | y löng t ||               | tlè thä ||               | t cöüld    ||               | nèêd mú    ||               | ltîplê l   ||               | ínès       |+---------------+------------+

After

+---------------+------------+| ISBN          | Title      |+---------------+------------+| 99921-58-10-7 | A really   ||               | long title ||               | that could ||               | need       ||               | multiple   ||               | lines      |+---------------+------------+| 99921-58-10-7 | Â rèälly   ||               | löng tîtlè ||               | thät cöüld ||               | nèêd       ||               | múltîplê   ||               | línès      |+---------------+------------+

maxbeckers requested a review fromchalasr as acode owner

August 2, 2023 09:05

carsonbot added Status: Needs Review Bug Console labels

Aug 2, 2023

Copy link

carsonbot commentedAug 2, 2023

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "5.4,".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

carsonbot added this to the6.4 milestone

Aug 2, 2023

maxbeckers changed the base branch from6.4 to5.4

August 2, 2023 09:05

maxbeckers force-pushed thepatch-42034_special_chars_in_console_table branch 2 times, most recently fromec4b7af todd95114Compare

August 2, 2023 09:09

derrabus modified the milestones:6.4,5.4

Aug 2, 2023

derrabus reviewed

Aug 2, 2023

View reviewed changes

src/Symfony/Component/Console/Formatter/OutputFormatter.php OutdatedShow resolvedHide resolved

OskarStark reviewed

Aug 2, 2023

View reviewed changes

src/Symfony/Component/Console/Formatter/OutputFormatter.php OutdatedShow resolvedHide resolved

derrabus reviewed

Aug 2, 2023

View reviewed changes

src/Symfony/Component/Console/Formatter/OutputFormatter.php OutdatedShow resolvedHide resolved

maxbeckers force-pushed thepatch-42034_special_chars_in_console_table branch fromdd95114 toc52f972Compare

August 2, 2023 09:34

nicolas-grekas reviewed

Aug 2, 2023

View reviewed changes

src/Symfony/Component/Console/Formatter/OutputFormatter.phpShow resolvedHide resolved

maxbeckers force-pushed thepatch-42034_special_chars_in_console_table branch 3 times, most recently frome4d46f7 to31dc48dCompare

August 3, 2023 13:12

maxbeckers commented

Aug 3, 2023

View reviewed changes

src/Symfony/Component/Console/Tests/Helper/TableTest.php

		80-902734-1-6 And Then There Were None Agatha Christie

		TABLE
		implode("\n", [

Copy link

ContributorAuthor

maxbeckersAug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change is only because of the line "trim_trailing_whitespace = true" in .editorconfig.

maxbeckers commented

Aug 3, 2023

View reviewed changes

src/Symfony/Component/Console/Tests/Helper/TableTest.php

		=============== ========================== ==================

		TABLE
		implode("\n", [

Copy link

ContributorAuthor

maxbeckersAug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change is only because of the line "trim_trailing_whitespace = true" in .editorconfig.

maxbeckers force-pushed thepatch-42034_special_chars_in_console_table branch from31dc48d to4d44010Compare

August 7, 2023 05:59

[Console] Fix linewraps in OutputFormatter

fcf86b3

maxbeckers force-pushed thepatch-42034_special_chars_in_console_table branch from4d44010 tofcf86b3Compare

August 7, 2023 06:12

chalasr reviewed

Aug 7, 2023

View reviewed changes

src/Symfony/Component/Console/Tests/Formatter/OutputFormatterTest.php

		$this->assertSame("pre \nfoo\nbar\nbaz \npost", $formatter->formatAndWrap('pre <error>foo bar baz</error> post', 4));
		$this->assertSame("pre f\noo\nbar\nbaz p\nost", $formatter->formatAndWrap('pre <error>foo bar baz</error> post', 5));
		$this->assertSame("Â rèälly\nlöng tîtlè\nthät cöüld\nnèêd\nmúltîplê\nlínès", $formatter->formatAndWrap('Â rèälly löng tîtlè thät cöüld nèêd múltîplê línès', 10));
		$this->assertSame("Â rèälly\nlöng tîtlè\nthät cöüld\nnèêd\nmúltîplê\n línès", $formatter->formatAndWrap("Â rèälly löng tîtlè thät cöüld nèêd múltîplê\n línès", 10));

Copy link

Member

chalasrAug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are all these changes on purpose and behave as expected?

Copy link

ContributorAuthor

maxbeckersAug 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes,@nicolas-grekas (seecomment) had the idea to use wordwrap from the string component for that. Wordwrap works a bit different with the line breaks than the regex before. now it breaks the line not in a word (or only if a word is longer than the full allowed length).
Example:
"Too long li\nne" => "Too long\nline"
IMHO this makes the output more readable.

nicolas-grekas approved these changes

Aug 14, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Aug 14, 2023

Copy link

Member

nicolas-grekas commentedAug 14, 2023

Thank you@maxbeckers.

nicolas-grekas merged commit370d5c0 intosymfony:5.4

Aug 14, 2023

This was referencedAug 26, 2023

Release v5.4.28#51495

Merged

Release v6.3.4#51496

Merged

renovatebot added a commit to Lendable/composer-license-checker that referenced this pull request

Aug 26, 2023

Update Composer runtime dependencies to v6.3.4 (#179)

09ab4e9

[![MendRenovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [symfony/console](https://symfony.com)([source](https://togithub.com/symfony/console)) | require | patch |`6.3.2` -> `6.3.4` || [symfony/process](https://symfony.com)([source](https://togithub.com/symfony/process)) | require | patch |`6.3.2` -> `6.3.4` |---### Release Notes<details><summary>symfony/console (symfony/console)</summary>### [`v6.3.4`](https://togithub.com/symfony/console/releases/tag/v6.3.4)[CompareSource](https://togithub.com/symfony/console/compare/v6.3.2...v6.3.4)**Changelog**(symfony/console@v6.3.3...v6.3.4)- bug[symfony/symfony#51378](https://togithub.com/symfony/symfony/issues/51378)\[Console] avoid multiple new line when message already ends with a newline in section output([@&#8203;joelwurtz](https://togithub.com/joelwurtz))- bug[symfony/symfony#51223](https://togithub.com/symfony/symfony/issues/51223)\[Console] Fix linewraps in `OutputFormatter` (@&#8203;maxbeckers)- bug[symfony/symfony#51355](https://togithub.com/symfony/symfony/issues/51355)\[Console] fix section output when multiples section with max height([@&#8203;joelwurtz](https://togithub.com/joelwurtz))</details><details><summary>symfony/process (symfony/process)</summary>###[`v6.3.4`](https://togithub.com/symfony/process/compare/v6.3.2...v6.3.4)[CompareSource](https://togithub.com/symfony/process/compare/v6.3.2...v6.3.4)</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined),Automerge - At any time (no schedule defined).🚦 **Automerge**: Enabled.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick therebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about theseupdates again.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [MendRenovate](https://www.mend.io/free-developer-tools/renovate/). Viewrepository job log[here](https://developer.mend.io/github/Lendable/composer-license-checker).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Labels

Bug Console Status: Reviewed

6 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[Console] Fix linewraps in`OutputFormatter`#51223

[Console] Fix linewraps in`OutputFormatter`#51223

Uh oh!

Conversation

maxbeckers commentedAug 2, 2023•
edited
Loading

Uh oh!

Uh oh!

carsonbot commentedAug 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxbeckersAug 3, 2023

Choose a reason for hiding this comment

Uh oh!

maxbeckersAug 3, 2023

Choose a reason for hiding this comment

Uh oh!

chalasrAug 7, 2023

Choose a reason for hiding this comment

Uh oh!

maxbeckersAug 8, 2023

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commentedAug 14, 2023

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

[Console] Fix linewraps inOutputFormatter#51223

[Console] Fix linewraps inOutputFormatter#51223

Uh oh!

Conversation

maxbeckers commentedAug 2, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

carsonbot commentedAug 2, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxbeckersAug 3, 2023

Choose a reason for hiding this comment

Uh oh!

maxbeckersAug 3, 2023

Choose a reason for hiding this comment

Uh oh!

chalasrAug 7, 2023

Choose a reason for hiding this comment

Uh oh!

maxbeckersAug 8, 2023

Choose a reason for hiding this comment

Uh oh!

nicolas-grekas commentedAug 14, 2023

Uh oh!

Uh oh!

[Console] Fix linewraps in`OutputFormatter`#51223

[Console] Fix linewraps in`OutputFormatter`#51223

maxbeckers commentedAug 2, 2023•
edited
Loading