Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] Add aTraceableWorkflow#51220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromlyrixx:workflow-traceable
Oct 20, 2023

Conversation

@lyrixx
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PR

image

image

Initially, I wanted to display the current marking on the graph, but it's not possible. "current" does not mean anything. What if I use the workflow for 2 entities? What if I call twiceapply(). Which marking should I choose? => this is not possible.

But, DoctrineBundle use ajax, like for explaining SQL request. It would be nice to be able to click on a marking, and it'll re-render the graph with this marking. WDYT?

andreybolonin, damienalexandre, magikid, and mtarld reacted with hooray emoji
@OskarStarkOskarStark changed the title[Worflow] Add a TraceableWorkflow[Worflow] Add aTraceableWorkflowAug 2, 2023
@carsonbotcarsonbot changed the title[Worflow] Add aTraceableWorkflow[Workflow] [Worflow] Add aTraceableWorkflowSep 11, 2023
@lyrixx
Copy link
MemberAuthor

This PR is ready for 2 month. I'm gonna merge it by the end of the week if there are not more review

94noni reacted with rocket emoji

@fabpotfabpot changed the title[Workflow] [Worflow] Add aTraceableWorkflow[Workflow] Add aTraceableWorkflowOct 10, 2023
@fabpot
Copy link
Member

@lyrixx Last call for 6.4 :)

@lyrixxlyrixxforce-pushed theworkflow-traceable branch 2 times, most recently from0c7dc40 to750aa14CompareOctober 19, 2023 09:08
@lyrixx
Copy link
MemberAuthor

Hello@fabpot,@stof and others reviewer.

I addressed your comments, I think the PR is ready 👍🏼

@lyrixxlyrixxforce-pushed theworkflow-traceable branch 4 times, most recently from2d5a6ee tod75ea2fCompareOctober 19, 2023 09:27
@fabpot
Copy link
Member

Thank you@lyrixx.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasAwaiting requested review from nicolas-grekas

+2 more reviewers

@HeahDudeHeahDudeHeahDude left review comments

@94noni94noni94noni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

6 participants

@lyrixx@fabpot@stof@94noni@HeahDude@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp