Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Workflow] List place and transition listeners in profiler#51211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromlyrixx:workflow-dc-listener
Oct 20, 2023

Conversation

@lyrixx
Copy link
Member

@lyrixxlyrixx commentedAug 1, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Ticketsfixes#50976
LicenseMIT
Doc PR

image

workflow.webm

welcoMattic, Nyholm, and adamwojs reacted with heart emoji
@lyrixxlyrixxforce-pushed theworkflow-dc-listener branch 3 times, most recently from4356844 tofbe6046CompareAugust 1, 2023 17:10
@lyrixxlyrixx changed the title[Workflow] List place or transition listeners in profiler[Workflow] List place and transition listeners in profilerAug 1, 2023
@lyrixx
Copy link
MemberAuthor

This PR is ready

@lyrixx
Copy link
MemberAuthor

This PR is ready for 2 month. I'm gonna merge it by the end of the week if there are not more review

@stofstof added the ❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze" labelOct 10, 2023
@stof
Copy link
Member

@lyrixx any chance to fix my latest comments

lyrixx reacted with thumbs up emoji

@lyrixx
Copy link
MemberAuthor

Hello@stof. I addressed your comment. Thanks

Copy link
Member

@nicolas-grekasnicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just one comment.
What about adding some tests?

@lyrixx
Copy link
MemberAuthor

@nicolas-grekas I added some tests 👍🏼

Copy link
Member

@fabpotfabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

fabbot has a patch for you :)

@lyrixxlyrixxforce-pushed theworkflow-dc-listener branch 2 times, most recently from6d8df3f tob69784fCompareOctober 20, 2023 08:44
@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit91a3a4f intosymfony:6.4Oct 20, 2023
@lyrixxlyrixx deleted the workflow-dc-listener branchOctober 20, 2023 09:08
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@stofstofstof requested changes

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

+1 more reviewer

@stloydstloydstloyd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature❄️ Feature FreezeImportant Pull Requests to finish before the next Symfony "feature freeze"Status: ReviewedWorkflow

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

Extend workflow component graph /debugger by event listener actions

6 participants

@lyrixx@stof@fabpot@stloyd@nicolas-grekas@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp