Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Workflow] Add PHP attributes to register listeners and guards#51210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/Symfony/Component/Workflow/Tests/Attribute/AsListenerTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Workflow/Tests/Attribute/AsListenerTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
src/Symfony/Component/Workflow/Tests/Attribute/AsListenerTest.php OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
lyrixx commentedAug 1, 2023
@nicolas-grekas Thanks for the review. I addressed your comments |
HeahDude left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
Uh oh!
There was an error while loading.Please reload this page.
nicolas-grekas commentedAug 3, 2023
Thank you@lyrixx. |
| int$priority =0, | ||
| string$dispatcher =null, | ||
| ) { | ||
| parent::__construct($this->buildEventName('announce','transition',$workflow,$transition),$method,$priority,$dispatcher); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| parent::__construct($this->buildEventName('announce','transition',$workflow,$transition),$method,$priority,$dispatcher); | |
| parent::__construct(self::buildEventName('announce','transition',$workflow,$transition),$method,$priority,$dispatcher); |
(same for other attributes)
nicolas-grekasAug 3, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
static:: then nvm, private method
Uh oh!
There was an error while loading.Please reload this page.
Allow this:
All theses syntax are supported:
Note: This is not possible to validate the workflow name,nor the transition name, because workflow can be build dynamically