Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Workflow] Add a profiler#51204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromlyrixx:workflow-data-collector
Aug 1, 2023
Merged

Conversation

lyrixx
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
Tickets
LicenseMIT
Doc PR

Withthis project lyrixx/SFLive-Paris2016-Workflow

image

workflow.webm

vtsykun, damienalexandre, onEXHovia, stloyd, Jibbarth, OskarStark, andreybolonin, TheCadien, rvanlaak, and alexislefebvre reacted with heart emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm totally a bad UI designer, so I found this on the web, and I adapted it a bit.
Feel free to replace it with something better

cc@jonathanlevaillant

rvanlaak reacted with heart emoji
@lyrixxlyrixxforce-pushed theworkflow-data-collector branch from1e9fc3f toe90147aCompareAugust 1, 2023 13:08
@lyrixxlyrixxforce-pushed theworkflow-data-collector branch frome90147a todf34d97CompareAugust 1, 2023 13:11
@lyrixxlyrixxforce-pushed theworkflow-data-collector branch from773f468 todf292cbCompareAugust 1, 2023 13:39
@stof
Copy link
Member

stof commentedAug 1, 2023

This panel does not collect any info related to the request. It only collect info about the configuration of the project, which will be the same for all requests. In the past, we removed some panels like that.

@lyrixx
Copy link
MemberAuthor

lyrixx commentedAug 1, 2023
edited
Loading

I thought about doing everything at runtime (I mean without all the collector stuff). But I changed my mind because the workflow can evolve between 2 requests. And we collect already some information about listener, doctrine entities. API-P does the same with the resources, and so on

And this panel isreally useful. I'm working on a new projet, with a huge workflow, and it helped me a lot to build the configuration.

And I plan to add more information to it, like the list of all event listeners. This features has been requested in#50976

So I wouldbe very happy to get this merged, it'll be a game changer for everyone using the workflow component

@fabpot
Copy link
Member

We already one such panel: "configuration"

@lyrixx
Copy link
MemberAuthor

lyrixx commentedAug 1, 2023
edited
Loading

Note: In future version, this panal will also display more things

  • The current marking of the subject (if a call has been made to the workflow obliviously)
  • Current content ofTransitionBlockerList
  • Perf metrics about all listeners

So it could not fit in the configuration panel

It will be something like the security panel : some configuration + some request related content

@94noni
Copy link
Contributor

i also find it useful even if not linked to request/response flow
reminds me#39114

OskarStark reacted with thumbs up emoji

@fabpot
Copy link
Member

Thank you@lyrixx.

@fabpotfabpot merged commit1300cc2 intosymfony:6.4Aug 1, 2023
@lyrixxlyrixx deleted the workflow-data-collector branchAugust 1, 2023 15:45
This was referencedOct 21, 2023
@andreybolonin
Copy link
Contributor

@lyrixx I used your WorkflowExtension to dump Workflow builded on the fly (in Controller), but I see some blocks is rendered on grey background

Screenshot 2023-10-24 at 13 03 53

How you fixed this?

I used the same code on frontend (mermaid.js and the same ver of bootstrap.min.css)

@lyrixx
Copy link
MemberAuthor

I'm not sure to understand your issue. Could could open a github discussion to talk about that? Thanks

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@stofstofstof left review comments

@94noni94noni94noni left review comments

@fabpotfabpotfabpot approved these changes

@nicolas-grekasnicolas-grekasnicolas-grekas approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

7 participants
@lyrixx@stof@fabpot@94noni@andreybolonin@nicolas-grekas@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp