Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Translation] Add--as-tree option totranslation:pull command#51153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
nicolas-grekas merged 1 commit intosymfony:6.4fromsyffer:translation-pull/add-as-tree-argument
Sep 20, 2023
Merged

[Translation] Add--as-tree option totranslation:pull command#51153

nicolas-grekas merged 1 commit intosymfony:6.4fromsyffer:translation-pull/add-as-tree-argument
Sep 20, 2023

Conversation

syffer
Copy link
Contributor

QA
Branch?6.4
Bug fix?yes/no
New feature?yes
Deprecations?no
Ticketsn/a
LicenseMIT
Doc PRtodo

This PR adds an option--as-tree to the commandtranslation:pull, like the PR#38393 did it for the commandtranslation:extract.

This option would ease the use of the commandtranslation:pull when the yaml translations are stored as a tree. Without it, the yaml translations are inlined after atranslation:pull, regardless of whether it was stored as inline or as a tree. To bypass this, you would either have to

  • re-indent the yaml file yourself after atranslation:pull
  • replace one service (e.g.translation.dumper.yaml) to forcefully add the optionas_tree for the yaml file dumper

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member

@NyholmNyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Lovely. Well done.

I like that you added tests for this feature.
I had a few comments that I would like your help addressing.

@OskarStarkOskarStark changed the title[Translation] Add option --as-tree to translation:pull command[Translation] Add--as-tree option totranslation:pull commandAug 2, 2023
Copy link
Member

@welcoMatticwelcoMattic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Little comment on the changelog, otherwise it's ok for me 👍. Thanks for your contribution

@nicolas-grekas
Copy link
Member

Thank you@syffer.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fabpotfabpotfabpot left review comments

@NyholmNyholmNyholm left review comments

@welcoMatticwelcoMatticwelcoMattic approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@syffer@carsonbot@nicolas-grekas@fabpot@welcoMattic@Nyholm
[8]ページ先頭
©2009-2025 Movatter.jp