NotificationsYou must be signed in to change notification settings
Fork9.6k
Star30.4k

[Scheduler] Add`AbstractTriggerDecorator`#51152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:6.4fromkbond:decorated-trigger

Jul 31, 2023

Merged

[Scheduler] Add`AbstractTriggerDecorator`#51152

fabpot merged 1 commit intosymfony:6.4fromkbond:decorated-trigger

Jul 31, 2023

Conversation

Copy link

Member

kbond commentedJul 28, 2023

Q	A
Branch?	6.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	n/a
License	MIT
Doc PR	n/a

I have a need to know what triggerdecorators are used and what thereal trigger is.

This PR adds anAbstractTriggerDecorator that the current decorators (Jitter &ExcludeTime) extend.

$trigger =newExcludeTimeTrigger(newJitterTrigger(CronExpressionTrigger::fromSpec('#midnight',newMyMessage()));$trigger->inner();// CronExpressionTrigger$trigger->decorators();// [ExcludeTimeTrigger, JitterTrigger]

carsonbot added Status: Needs Review Feature Scheduler labels

Jul 28, 2023

carsonbot added this to the6.4 milestone

Jul 28, 2023

[Scheduler] AddAbstractTriggerDecorator

3ca7eb3

kbond force-pushed thedecorated-trigger branch from4eef909 to3ca7eb3Compare

July 28, 2023 20:06

OskarStark approved these changes

Jul 29, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 29, 2023

Copy link

Member

fabpot commentedJul 29, 2023

Can you tell use more about your use case?

Copy link

MemberAuthor

kbond commentedJul 29, 2023

Sure!

I'm building a scheduler dashboard and would like to translate cron strings to a human readable format. I need to find the inner-most trigger to do this.
A scheduler monitoring service I'm building an integration for only supports cron expressions. It's ok to use with a jitter wrapped cron, but not an exclude time wrapped cron.