Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Templating] deprecate the component#51144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromkbond:deprecate-templating
Jul 30, 2023

Conversation

kbond
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?yes
Ticketsn/a
LicenseMIT
Doc PRn/a

I think it's time to deprecate/remove this component.

ro0NL reacted with heart emoji
@kbond
Copy link
MemberAuthor

I'm not sure how to suppress the deprecations. I've added@group legacy to the test classes but I guess the deprecations are triggered earlier?

@GromNaN
Copy link
Member

GromNaN commentedJul 28, 2023•
edited
Loading

The component isstill downloaded 30K/day. Not on legacy projects since there is 6.4K daily installs for the v6.
image

@kbond
Copy link
MemberAuthor

I think a good chunk of the downloads are transient. For instance,knplabs/knp-time-bundle requires it and has ~4k daily downloads.

GromNaN, derrabus, and Koc reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

👍 for the proposal. Deprecating it will still mean maintaining it for the duration of the LTS, so 3 more years.

derrabus reacted with thumbs up emoji

@nicolas-grekas
Copy link
Member

Any corresponding config tree in frameworkbundle that should also be deprecated?

@derrabus
Copy link
Member

Any corresponding config tree in frameworkbundle that should also be deprecated?

Didn't this happen in#32267 already?

nicolas-grekas reacted with thumbs up emojinicolas-grekas reacted with hooray emoji

@fabpot
Copy link
Member

Thank you@kbond.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@nicolas-grekasnicolas-grekasnicolas-grekas left review comments

@fabpotfabpotfabpot approved these changes

@GromNaNGromNaNGromNaN approved these changes

@derrabusderrabusderrabus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

6 participants
@kbond@GromNaN@nicolas-grekas@derrabus@fabpot@carsonbot
[8]ページ先頭
©2009-2025 Movatter.jp