Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Scheduler] Postpone schedule creation#51138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| "doctrine/dbal":"^2.13.1|^3.0", | ||
| "doctrine/orm":"^2.12", | ||
| "dragonmantank/cron-expression":"^3", | ||
| "dragonmantank/cron-expression":"^3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sync up withsrc/Symfony/Component/Scheduler/composer.json, lowest deps fail otherwise.
kbond left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@HypeMC, this makes sense to me.
fabpot commentedJul 29, 2023
Thank you@HypeMC. |
The issue is caused by the
MessengerTransportDoctrineSchemaListenerwhich is triggered whendoctrine:schema:createis run. Itinstantiates all transports which causes theScheduleProviderInterface::getSchedule()method to be called, but since the schema is not yet created, everything breaks.This PR changes the
MessageGeneratorclass to accept theScheduleProviderInterfaceinstead of onlySchedule. That way the call togetSchedule()can be postponed to when it's really needed, and since theSheduleclass implements theScheduleProviderInterface, there's no breaking change.