Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.6k
[DependencyInjection] Add test for issue #49591#51123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:6.3
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJul 27, 2023
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
| $dumper = new PhpDumper($containerBuilder); | ||
| $dump = $dumper->dump(['class' => 'Symfony_DI_PhpDumper_Issues49591']); | ||
| self::assertStringEqualsFile(__DIR__.'/Fixtures/php/services_issues49591.php', $dump); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is the assertion that fails currently. But as far as I understood the issue, the actual issue is reproduced by the following assertion. Do we need this fixture anyway? Doesn't comparing the dump to the fixture only make the test brittle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No, it's really not needed, I only added it so that the dumped container can be seen as it might help to understand the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've removed the assertion & updated the dump for version 6.3 (I originally generated it with 6.2).
It looks like a cyclic dependency. Perhaps the right solution would be throw a
|
Uh oh!
There was an error while loading.Please reload this page.
A simple test case to illustrate the problem.