NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Runtime] Fix property must not be accessed before initialization on SymfonyRuntime#51111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit intosymfony:6.4froml-vo:fix_property_must_not_be_accessed_before_initialization_runtime

Jul 26, 2023

Merged

[Runtime] Fix property must not be accessed before initialization on SymfonyRuntime#51111

nicolas-grekas merged 1 commit intosymfony:6.4froml-vo:fix_property_must_not_be_accessed_before_initialization_runtime

Jul 26, 2023

Conversation

Copy link

Contributor

l-vo commentedJul 26, 2023

Q	A
Branch?	6.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT
Doc PR	symfony/symfony-docs#...

Introduced by#51068, see#51068 (comment)

Fix property must not be accessed before initialization on SymfonyRun…

dd3c406

…time::$input

carsonbot added Status: Needs Review Bug labels

Jul 26, 2023

carsonbot added this to the6.4 milestone

Jul 26, 2023

derrabus approved these changes

Jul 26, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 26, 2023

derrabus added Status: Needs Review Runtime and removed Status: Reviewed labels

Jul 26, 2023

carsonbot changed the title~~Fix property must not be accessed before initialization on SymfonyRuntime~~[Runtime] Fix property must not be accessed before initialization on SymfonyRuntime

Jul 26, 2023

xabbuh approved these changes

Jul 26, 2023

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

Jul 26, 2023

Copy link

Member

nicolas-grekas commentedJul 26, 2023

Thank you@l-vo.

nicolas-grekas merged commitad72245 intosymfony:6.4

Jul 26, 2023

l-vo deleted the fix_property_must_not_be_accessed_before_initialization_runtime branch

July 26, 2023 09:23

Copy link

Contributor

PhilETaylor commentedJul 26, 2023

Awesome - thanks@l-vo, this indeed addresses and fixes the#51068 (comment)

Copy link

Contributor

PhilETaylor commentedJul 28, 2023

@nicolas-grekas any chance of pushing this tohttps://github.com/symfony/runtime/tree/6.4 because at the moment 6.4-dev runtime is broken because of this one

Fatal error: Uncaught Error: Typed property Symfony\Component\Runtime\SymfonyRuntime::$input must not be accessed before initialization in /var/www/current/vendor/symfony/runtime/SymfonyRuntime.php:109 Stack trace: #0 /var/www/current/vendor/autoload_runtime.php(16): Symfony\Component\Runtime\SymfonyRuntime->__construct() #1 /var/www/current/public/index.php(13): require_once('...') #2 {main} thrown in /var/www/current/vendor/symfony/runtime/SymfonyRuntime.php on line 109

Copy link

Member

nicolas-grekas commentedJul 28, 2023

We have an issue with the splitter, it should be fixed in the very next days if not hours.
Thanks for sponsoring me BTW!

Copy link

Contributor

PhilETaylor commentedJul 28, 2023

We have an issue with the splitter, it should be fixed in the very next days if not hours.

ah no worries - sorry to hear that. Absolutely no pressure from me!

Thanks for sponsoring me BTW!

It's only small amounts but Im sure they add up somehow.

Copy link

Member

derrabus commentedJul 28, 2023

We're having trouble with our subtree splitter at the moment. Bear with us.

Copy link

Contributor

PhilETaylor commentedJul 28, 2023

We're having trouble with our subtree splitter at the moment. Bear with us.

Absolutely! There is no pressure from me at all - thanks for letting me know though. I have manually worked around this bug this week, and will continue to all weekend :) no pressure this end, and now I know the reason it was not split. :)