NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Routing] Remove Doctrine annotations support#51082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit intosymfony:7.0fromderrabus:remove/routing-annotations

Jul 26, 2023

Merged

[Routing] Remove Doctrine annotations support#51082

fabpot merged 1 commit intosymfony:7.0fromderrabus:remove/routing-annotations

Jul 26, 2023

Conversation

Copy link

Member

derrabus commentedJul 24, 2023

Q	A
Branch?	7.0
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Follows#49358
License	MIT
Doc PR	symfony/symfony-docs#18589

carsonbot added Status: Needs Review Feature Routing labels

Jul 24, 2023

carsonbot added this to the7.0 milestone

Jul 24, 2023

derrabus force-pushed theremove/routing-annotations branch 3 times, most recently from987823d to0114d73Compare

July 24, 2023 12:27

derrabus commented

Jul 24, 2023

View reviewed changes

...nt/Routing/Tests/Fixtures/AttributeFixtures/LocalizedPrefixMissingLocaleActionController.phpShow resolvedHide resolved

derrabus mentioned this pull request

Jul 24, 2023

[Routing] FixtestMissingPrefixLocale andtestMissingRouteLocale#51084

Merged

nicolas-grekas added a commit that referenced this pull request

Jul 24, 2023

minor#51084[Routing] FixtestMissingPrefixLocaleand `testMissing…

8b82019

…RouteLocale` (derrabus)This PR was merged into the 5.4 branch.Discussion----------[Routing] Fix `testMissingPrefixLocale` and `testMissingRouteLocale`| Q             | A| ------------- | ---| Branch?       | 5.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       |#51082 (comment)| License       | MIT| Doc PR        | not neededThose two fixtures only exist as annotation versions. Their attribute counterparts were missing.The corresponding tests only expected a `LogicException` which is what `AnnotationClassLoader` would raise for undefined classes as well.This PR adds new assertions for the exception messages which would have discovered the missing fixtures. Finally, the two missing fixtures are added.Commits-------6ba9864 [Routing] Fix testMissingPrefixLocale and testMissingRouteLocale