Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add types to private and internal properties#51068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nicolas-grekas
Copy link
Member

QA
Branch?6.4
Bug fix?no
New feature?no
Deprecations?no
Tickets-
LicenseMIT
Doc PR-

BafS reacted with rocket emoji
@xabbuh
Copy link
Member

The failures look related.

@nicolas-grekasnicolas-grekasforce-pushed thetyped-private-props branch 7 times, most recently fromd382bd0 to64a6035CompareJuly 25, 2023 14:47
@nicolas-grekasnicolas-grekas changed the titleAdd types to private propertiesAdd types to private and internal propertiesJul 25, 2023
@nicolas-grekas
Copy link
MemberAuthor

PR green, comments addressed.

@nicolas-grekasnicolas-grekas merged commit0bac246 intosymfony:6.4Jul 25, 2023
@nicolas-grekasnicolas-grekas deleted the typed-private-props branchJuly 25, 2023 15:45
@PhilETaylor
Copy link
Contributor

PhilETaylor commentedJul 25, 2023
edited
Loading

I did a composer update and now I get white screen of death (the actual error below) AMA

Fatal error: Uncaught Error: Typed property Symfony\Component\Runtime\SymfonyRuntime::$input must not be accessed before initialization in /var/www/current/vendor/symfony/runtime/SymfonyRuntime.php:109 Stack trace: #0 /var/www/current/vendor/autoload_runtime.php(16): Symfony\Component\Runtime\SymfonyRuntime->__construct()#1 /var/www/current/public/index.php(13): require_once('...')#2 {main} thrown in /var/www/current/vendor/symfony/runtime/SymfonyRuntime.php on line 109

installed version
symfony/runtime: '6.4.x-dev#58f074a10fed1094ca7a2bb753c36983790fdb29'

@PhilETaylor
Copy link
Contributor

Moving the$this->getInput(); out of theelseif statement in the constructor ofSymfonyRuntime seems to fix the issue for me but Im unsure of any knock on affects.

from this:

if (isset($options['env'])) {$_SERVER[$envKey] =$options['env'];        }elseif (isset($_SERVER['argv']) &&class_exists(ArgvInput::class)) {$this->options =$options;$this->getInput();        }

to this

if (isset($options['env'])) {$_SERVER[$envKey] =$options['env'];        }elseif (isset($_SERVER['argv']) &&class_exists(ArgvInput::class)) {$this->options =$options;        }$this->getInput();

nicolas-grekas added a commit that referenced this pull requestJul 26, 2023
…alization on SymfonyRuntime (l-vo)This PR was merged into the 6.4 branch.Discussion----------[Runtime] Fix property must not be accessed before initialization on SymfonyRuntime| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       || License       | MIT| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->Introduced by#51068, see#51068 (comment)Commits-------dd3c406 Fix property must not be accessed before initialization on SymfonyRuntime::$input
nicolas-grekas added a commit that referenced this pull requestJul 28, 2023
…grekas)This PR was merged into the 7.0 branch.Discussion----------Add types to public and protected properties| Q             | A| ------------- | ---| Branch?       | 7.0| Bug fix?      | no| New feature?  | yes| Deprecations? | no| Tickets       | -| License       | MIT| Doc PR        | -:hot_face:Allowed by#45360Follows#51068 and#51067Commits-------7ea2461 Add types to public and protected properties
fabpot added a commit that referenced this pull requestOct 16, 2023
…ulting in bad argument (weaverryan)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Process] Fix bug where $this->callback is never null, resulting in bad argument| Q             | A| ------------- | ---| Branch?       | 6.4| Bug fix?      | yes| New feature?  | no| Deprecations? | no| Tickets       | None| License       | MIT| Doc PR        | Not neededHi!Caused by#51068 - by the time `$this->getDescriptors()` is called, `$this->callback` is ALWAYS a callable thanks to `$this->callback = $this->buildCallback($callback)`.Previously, there was a separate `hasCallback` property that handled this logic. I chose to NOT re-add that because it was only needed in `getDescriptors()` and that is only called from this one place: easier to pass `$hasCallback` as an argument.Caught by the symfony/ux test suite ❤️Cheers!Commits-------95aa236 [Process] Fix bug where $this->callback is never null, resulting in bad argument
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@derrabusderrabusderrabus left review comments

@ycerutoycerutoAwaiting requested review from ycerutoyceruto is a code owner

@OskarStarkOskarStarkAwaiting requested review from OskarStarkOskarStark is a code owner

@jderussejderusseAwaiting requested review from jderussejderusse is a code owner

@xabbuhxabbuhAwaiting requested review from xabbuhxabbuh is a code owner

@chalasrchalasrAwaiting requested review from chalasrchalasr is a code owner

@wouterjwouterjAwaiting requested review from wouterj

@dunglasdunglasAwaiting requested review from dunglasdunglas is a code owner

+1 more reviewer

@stloydstloydstloyd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

6 participants

@nicolas-grekas@xabbuh@PhilETaylor@stloyd@derrabus@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp