Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
Add types to private and internal properties#51068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
nicolas-grekas commentedJul 21, 2023
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
xabbuh commentedJul 21, 2023
The failures look related. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
009f699 tod2bdeb0Compared2bdeb0 to67da982Compared382bd0 to64a6035Compare64a6035 to6353f5eComparenicolas-grekas commentedJul 25, 2023
PR green, comments addressed. |
PhilETaylor commentedJul 25, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I did a composer update and now I get white screen of death (the actual error below) AMA
installed version |
PhilETaylor commentedJul 25, 2023
Moving the from this: if (isset($options['env'])) {$_SERVER[$envKey] =$options['env']; }elseif (isset($_SERVER['argv']) &&class_exists(ArgvInput::class)) {$this->options =$options;$this->getInput(); } to this if (isset($options['env'])) {$_SERVER[$envKey] =$options['env']; }elseif (isset($_SERVER['argv']) &&class_exists(ArgvInput::class)) {$this->options =$options; }$this->getInput(); |
…alization on SymfonyRuntime (l-vo)This PR was merged into the 6.4 branch.Discussion----------[Runtime] Fix property must not be accessed before initialization on SymfonyRuntime| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets || License | MIT| Doc PR | symfony/symfony-docs#... <!-- required for new features -->Introduced by#51068, see#51068 (comment)Commits-------dd3c406 Fix property must not be accessed before initialization on SymfonyRuntime::$input
…grekas)This PR was merged into the 7.0 branch.Discussion----------Add types to public and protected properties| Q | A| ------------- | ---| Branch? | 7.0| Bug fix? | no| New feature? | yes| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -:hot_face:Allowed by#45360Follows#51068 and#51067Commits-------7ea2461 Add types to public and protected properties
…ulting in bad argument (weaverryan)This PR was squashed before being merged into the 6.4 branch.Discussion----------[Process] Fix bug where $this->callback is never null, resulting in bad argument| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | yes| New feature? | no| Deprecations? | no| Tickets | None| License | MIT| Doc PR | Not neededHi!Caused by#51068 - by the time `$this->getDescriptors()` is called, `$this->callback` is ALWAYS a callable thanks to `$this->callback = $this->buildCallback($callback)`.Previously, there was a separate `hasCallback` property that handled this logic. I chose to NOT re-add that because it was only needed in `getDescriptors()` and that is only called from this one place: easier to pass `$hasCallback` as an argument.Caught by the symfony/ux test suite ❤️Cheers!Commits-------95aa236 [Process] Fix bug where $this->callback is never null, resulting in bad argument