Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[AssetMapper] Fixing import parsing from jsdelivr#51065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:6.3fromweaverryan:asset-mapper-jsdelivr-regexJul 21, 2023
Merged
[AssetMapper] Fixing import parsing from jsdelivr#51065
nicolas-grekas merged 1 commit intosymfony:6.3fromweaverryan:asset-mapper-jsdelivr-regexJul 21, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
If a package imported 2x other packages, both where the package had nonamespace (i.e. no "@" in the name), the 2 packages would be matched as one incorrectly.
Contributor
bendavies commentedJul 21, 2023
nice! |
Member
nicolas-grekas commentedJul 21, 2023
Thank you@weaverryan. |
Merged
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found with:https://cdn.jsdelivr.net/npm/bootstrap@4.6.2/+esm
With the
importmap:require --downloadoption, we parse thoseimportstatements to discover which dependencies we also need to download. If a package required 2 imports and both donot have an@in their name (i.e. a namespaced package), the regex matched both package strings as a single package - so it would see the package name asjquery@3.7.0/+esm";import e from"/npm/popper.js@1.16.1/+esm.Cheers!