Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Messenger] Remove deprecatedStopWorkerOnSignalsListener#51064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
nicolas-grekas merged 1 commit intosymfony:7.0fromHypeMC:remove-deprecated-stopworkeronsignalslistenerJul 26, 2023
Merged
[Messenger] Remove deprecatedStopWorkerOnSignalsListener#51064
nicolas-grekas merged 1 commit intosymfony:7.0fromHypeMC:remove-deprecated-stopworkeronsignalslistenerJul 26, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
nicolas-grekas commentedJul 21, 2023
Looks like this would break 6.4? Can you have a look? |
MemberAuthor
HypeMC commentedJul 24, 2023
@nicolas-grekas Done, see#51093 |
derrabus added a commit that referenced this pull requestJul 25, 2023
This PR was merged into the 6.4 branch.Discussion----------[FrameworkBundle] Fix using messenger 7.0| Q | A| ------------- | ---| Branch? | 6.4| Bug fix? | no| New feature? | no| Deprecations? | no| Tickets | -| License | MIT| Doc PR | -Makes sure messenger v7.0 wouldn't break, see#51064 (comment). Could be update for#50787 (comment) as well.Commits-------9a45ae0 [FrameworkBundle] Fix using messenger 7.0
Member
derrabus commentedJul 25, 2023
Please rebase. 🙂 |
be40658 to4366044CompareMemberAuthor
HypeMC commentedJul 25, 2023
@derrabus Done, fabbot failure is unrelated. |
xabbuh approved these changesJul 26, 2023
Member
nicolas-grekas commentedJul 26, 2023
Thank you@HypeMC. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to#50997.