Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Mailer] [Mailgun] Disable tls for mailgun as it should use STARTTLS#51042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
joelwurtz commentedJul 20, 2023
Ref#34846 (comment) for more explanation |
xabbuh approved these changesJul 20, 2023
Member
nicolas-grekas commentedJul 21, 2023
Thank you@joelwurtz |
Merged
nicolas-grekas added a commit that referenced this pull requestDec 19, 2023
…e STARTTLS (RFreij)This PR was merged into the 6.4 branch.Discussion----------[Mailer] [Mailjet] Disable tls for mailjet as it should use STARTTLS| Q | A| ------------- | ---| Branch? | 6.4 <!-- see below -->| Bug fix? | yes| New feature? | no <!-- please update src/**/CHANGELOG.md files -->| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->| Issues | <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->| License | MIT#52560 updates the default mailjet port and references the same change for mailgun.Similar to#51042 and with the same error message, the mailjet connection doesn't work now.The PR above already has a reference, but for completion sake: Ref#34846 (comment) for more explanationCommits-------709d56f fix(mailjet-smtp): disable tls for mailjet as it should use starttls instead
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since symfony 6.3 smtp mailgun use 587 as default port with tls true, but it does not work :
Setting tls to false, force the smtp transport to try to use STARTTLS if available like others smtp providers (mailchimp in example)