Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork9.7k
[Intl] Fixed directory traversal in emoji compression tool#51030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
carsonbot commentedJul 19, 2023
Hey! I see that this is your first PR. That is great! Welcome! Symfony has acontribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
carsonbot commentedJul 19, 2023
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
| $file_iterator =newRecursiveIteratorIterator( | ||
| newRecursiveDirectoryIterator( | ||
| dirname(__DIR__).'/data', | ||
| FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS | ||
| ) | ||
| ); | ||
| foreach ($file_iteratoras$file) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we use camelCase for variables:
| $file_iterator = new RecursiveIteratorIterator( | |
| new RecursiveDirectoryIterator( | |
| dirname(__DIR__).'/data', | |
| FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS | |
| ) | |
| ); | |
| foreach ($file_iterator as $file) { | |
| $iterator = new RecursiveIteratorIterator( | |
| new RecursiveDirectoryIterator( | |
| dirname(__DIR__).'/data', | |
| FilesystemIterator::CURRENT_AS_FILEINFO | FilesystemIterator::SKIP_DOTS | |
| ) | |
| ); | |
| foreach ($iterator as $file) { |
nicolas-grekas commentedJul 20, 2023
Thanks for the update. Can you please squash the two commits in one? I would have done it but "Allow edits from maintainer" is disabled so I can't. |
When using the compression tool, the emoji data is not compressed properly due to directory traversal issues. It only goes one level deep in the `data' directory.
rlandgrebe commentedJul 20, 2023
Thanks for your feedback, Nicolas. I just squashed the two commits into one. |
nicolas-grekas commentedJul 20, 2023
Thank you@rlandgrebe. |
When using the compression tool, the emoji data is not compressed properly due to directory traversal issues. It only goes one level deep in the `data' directory.