NotificationsYou must be signed in to change notification settings
Fork9.7k
Star30.8k

[Validator] Fix constraints merge for protected and public properties#51027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

kontsevoye wants to merge1 commit intosymfony:5.4fromkontsevoye:validator-metadata-patch

Closed

[Validator] Fix constraints merge for protected and public properties#51027

kontsevoye wants to merge1 commit intosymfony:5.4fromkontsevoye:validator-metadata-patch

Conversation

Copy link

kontsevoye commentedJul 19, 2023•
edited
Loading

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	-
License	MIT
Doc PR	-

There was backward compatibility break insymfony/validator@81772c1.

When you have a parent class with a public or protected property that has a constraint, and a child class that also has a constraint for the same property, you need to merge them rather than override them.

[Validator] Fix constraints merge for protected and public properties

47e493d

carsonbot added Status: Needs Review Bug Validator labels

Jul 19, 2023

carsonbot added this to the5.4 milestone

Jul 19, 2023

Copy link

carsonbot commentedJul 19, 2023

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

Always add tests
Keep backward compatibility (seehttps://symfony.com/bc).
Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot