Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Mailer] Add Scaleway bridge#51014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
fabpot merged 1 commit intosymfony:6.4fromMrMicky-FR:scaleway_mailer
Jul 30, 2023
Merged

[Mailer] Add Scaleway bridge#51014

fabpot merged 1 commit intosymfony:6.4fromMrMicky-FR:scaleway_mailer
Jul 30, 2023

Conversation

MrMicky-FR
Copy link
Contributor

@MrMicky-FRMrMicky-FR commentedJul 18, 2023•
edited
Loading

QA
Branch?6.4
Bug fix?no
New feature?yes
Deprecations?no
LicenseMIT
Doc PRsymfony/symfony-docs#18581

This PR adds a new mailer bridge forScaleway Transactional Emails.

I've been using this bridge in production for several months, with thousands of emails sent, and everything works perfectly 🚀

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has acontribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (seehttps://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (seehttps://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

MrMicky-FR reacted with rocket emoji

@MrMicky-FR
Copy link
ContributorAuthor

Thanks for your feedback, I've committed the changes

@fabpot
Copy link
Member

Thank you@MrMicky-FR.

@fabpotfabpot merged commit767a7ef intosymfony:6.4Jul 30, 2023
@fabpot
Copy link
Member

@MrMicky-FR Can you submit a PR on symfony/recipes for this mailer?

MrMicky-FR reacted with thumbs up emoji

@MrMicky-FRMrMicky-FR deleted the scaleway_mailer branchJuly 30, 2023 17:13
OskarStark added a commit to symfony/symfony-docs that referenced this pull requestJul 31, 2023
This PR was squashed before being merged into the 6.4 branch.Discussion----------[Mailer] Add Scaleway bridge documentationThis PR adds documentation for*symfony/symfony#51014Commits-------cdf8811 [Mailer] Add Scaleway bridge documentation
This was referencedOct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@derrabusderrabusderrabus left review comments

@fabpotfabpotfabpot approved these changes

@OskarStarkOskarStarkOskarStark approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

5 participants
@MrMicky-FR@carsonbot@fabpot@OskarStark@derrabus
[8]ページ先頭
©2009-2025 Movatter.jp